Re: [PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-06 Thread Doug Anderson
Paul, On Tue, Aug 5, 2014 at 1:08 PM, Paul Zimmerman wrote: >> Maybe dwc2 is refer to the Kconfig in dwc3 for there is a choice from >> one of "Host only mode", "Gadget only mode" and "Dual Role mode", >> which means the role is decided by the Kconfig. >> >> In my opinion, there maybe more than o

RE: [PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-05 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Monday, August 04, 2014 6:46 PM > > On 08/05/2014 12:34 AM, Doug Anderson wrote: > > > Normally I'd say that you should have added Paul's "Acked-by" since > > you fixed his nit and he told you to include his Acked-by when his nit > > w

Re: [PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-04 Thread Doug Anderson
Kever, On Mon, Aug 4, 2014 at 6:45 PM, Kever Yang wrote: > Doug, > > > On 08/05/2014 12:34 AM, Doug Anderson wrote: >> >> Kever, >> >> On Mon, Aug 4, 2014 at 6:45 AM, Kever Yang >> wrote: >>> >>> According to the "dr_mode", the otg controller can work as >>> device role during firmware period, a

Re: [PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-04 Thread Kever Yang
Doug, On 08/05/2014 12:34 AM, Doug Anderson wrote: Kever, On Mon, Aug 4, 2014 at 6:45 AM, Kever Yang wrote: According to the "dr_mode", the otg controller can work as device role during firmware period, and work as host role in the kernel, without use of usb_id pin. As the commit "usb: dwc3:

Re: [PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-04 Thread Doug Anderson
Kever, On Mon, Aug 4, 2014 at 6:45 AM, Kever Yang wrote: > According to the "dr_mode", the otg controller can work as > device role during firmware period, and work as host role in > the kernel, without use of usb_id pin. As the commit "usb: dwc3: > set 'mode' based on selected Kconfig choices".

[PATCH v3 2/2] usb: dwc2: add 'mode' which based on Kconfig select or dts setting

2014-08-04 Thread Kever Yang
According to the "dr_mode", the otg controller can work as device role during firmware period, and work as host role in the kernel, without use of usb_id pin. As the commit "usb: dwc3: set 'mode' based on selected Kconfig choices". Signed-off-by: Kever Yang --- Changes in v3: - fix the odd spac