Re: [PATCH v3 15/16] usb: musb: da8xx: Use devm in probe

2016-04-01 Thread Bin Liu
Hi, On Thu, Mar 31, 2016 at 05:28:48PM -0500, David Lechner wrote: > On 03/31/2016 05:21 PM, Bin Liu wrote: > > >>- glue = kzalloc(sizeof(*glue), GFP_KERNEL); > >>+ glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL); > >>if (!glue) { > >>dev_err(&pdev->dev, "failed to

Re: [PATCH v3 15/16] usb: musb: da8xx: Use devm in probe

2016-04-01 Thread Sergei Shtylyov
Hello. On 4/1/2016 1:21 AM, Bin Liu wrote: Simplify things a bit by using devm functions where possible. Signed-off-by: David Lechner --- v3 changes: * Kept clk variable to minimize noise. drivers/usb/musb/da8xx.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(

Re: [PATCH v3 15/16] usb: musb: da8xx: Use devm in probe

2016-03-31 Thread David Lechner
On 03/31/2016 05:21 PM, Bin Liu wrote: - glue = kzalloc(sizeof(*glue), GFP_KERNEL); + glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL); if (!glue) { dev_err(&pdev->dev, "failed to allocate glue context\n"); - goto err0; +

Re: [PATCH v3 15/16] usb: musb: da8xx: Use devm in probe

2016-03-31 Thread Bin Liu
Hi, On Thu, Mar 24, 2016 at 06:51:40PM -0500, David Lechner wrote: > Simplify things a bit by using devm functions where possible. > > Signed-off-by: David Lechner > --- > > v3 changes: > > * Kept clk variable to minimize noise. > > > drivers/usb/musb/da8xx.c | 19 +-- > 1 f

[PATCH v3 15/16] usb: musb: da8xx: Use devm in probe

2016-03-24 Thread David Lechner
Simplify things a bit by using devm functions where possible. Signed-off-by: David Lechner --- v3 changes: * Kept clk variable to minimize noise. drivers/usb/musb/da8xx.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/usb/musb/da8xx.c b/drive