Hi Morimoto-san,
> > + if (priv->phy) {
> > + phy_put(priv->phy);
> > + priv->phy = NULL;
> > + }
> > +
> > + return 0;
> > +}
>
> phy_put() will do nothing if priv->phy was NULL.
> We can remove if() here ?
OK. I will remove 'if'.
#I copied Shimoda-san's code from rca
Hi Shimoda-san,
> From: Yoshihiro Shimoda
> Sent: Wednesday, May 15, 2019 3:53 AM
> > +#include "rza.h"
> > +
> > +
>
> I should have realized this on v2 patch though, this double blank lines
> should be a line. After fixed it,
OK, I will remove it and resend.
Chris
Hi Chris
> +static int usbhs_rza2_hardware_exit(struct platform_device *pdev)
> +{
> + struct usbhs_priv *priv = usbhs_pdev_to_priv(pdev);
> +
> + if (priv->phy) {
> + phy_put(priv->phy);
> + priv->phy = NULL;
> + }
> +
> + return 0;
> +}
phy_put() will d
On Tue, May 14, 2019 at 09:56:01AM -0500, Chris Brandt wrote:
> The RZ/A2 is similar to the R-Car Gen3 with some small differences.
>
> Signed-off-by: Chris Brandt
Reviewed-by: Simon Horman
Hi Chris-san,
Thank you for the patch!
> From: Chris Brandt, Sent: Tuesday, May 14, 2019 11:56 PM
>
> The RZ/A2 is similar to the R-Car Gen3 with some small differences.
>
> Signed-off-by: Chris Brandt
> ---
> v3:
> * Removed check for CONFIG_GENERIC_PHY
> * rebase on top of Shimoda-san (v2)
The RZ/A2 is similar to the R-Car Gen3 with some small differences.
Signed-off-by: Chris Brandt
---
v3:
* Removed check for CONFIG_GENERIC_PHY
* rebase on top of Shimoda-san (v2) patch
v2:
* combined RZA1 and RZA2 for fifo setting
* added braces to make code easier to read
* fixed and clean
