Re: [PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API

2013-11-04 Thread Shawn Guo
On Tue, Nov 05, 2013 at 10:59:17AM +0800, Peter Chen wrote: > > > @@ -83,6 +90,15 @@ > > > */ > > > #define MXS_PHY_SENDING_SOF_TOO_FAST BIT(2) > > > > > > +/* imx23 style PHY */ > > > +#define MXS_PHY_IMX23BIT(3) > > > + > > > +/* imx6q style PHY */ > >

Re: [PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API

2013-11-04 Thread Peter Chen
On Tue, Nov 05, 2013 at 11:05:15AM +0800, Shawn Guo wrote: > On Tue, Nov 05, 2013 at 09:49:43AM +0800, Peter Chen wrote: > > We need this to keep PHY's power on or off during the system > > suspend mode. If we need to enable USB wakeup, then we > > must keep PHY's power being on during the system s

Re: [PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API

2013-11-04 Thread Shawn Guo
On Tue, Nov 05, 2013 at 09:49:43AM +0800, Peter Chen wrote: > We need this to keep PHY's power on or off during the system > suspend mode. If we need to enable USB wakeup, then we > must keep PHY's power being on during the system suspend mode. > Otherwise, we need to keep PHY's power being off to

[PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API

2013-11-04 Thread Peter Chen
We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs