Re: [PATCH v3 06/11] usb: musb: factor out hcd initalization

2013-04-10 Thread Peter Korsgaard
> "Daniel" == Daniel Mack writes: Hi, >> Just that it's an unneeded extra level of indirection. Daniel> Ok, alright. Sent v4 right now. Thanks! Daniel> Thanks for your feedback! Much appreciated. Btw - did you try Daniel> that on your board yet? Does it work for you as well? Sorry, n

Re: [PATCH v3 06/11] usb: musb: factor out hcd initalization

2013-04-10 Thread Daniel Mack
On 10.04.2013 21:15, Peter Korsgaard wrote: >> "Daniel" == Daniel Mack writes: > > Hi, > > Daniel> +struct musb_hcd_link { > Daniel> +struct musb *musb; > Daniel> +}; > Daniel> + > Daniel> +struct musb *hcd_to_musb(struct usb_hcd *hcd) > Daniel> +{ > Daniel> +struct musb_hcd_l

Re: [PATCH v3 06/11] usb: musb: factor out hcd initalization

2013-04-10 Thread Peter Korsgaard
> "Daniel" == Daniel Mack writes: Hi, Daniel> +struct musb_hcd_link { Daniel> + struct musb *musb; Daniel> +}; Daniel> + Daniel> +struct musb *hcd_to_musb(struct usb_hcd *hcd) Daniel> +{ Daniel> + struct musb_hcd_link *link = (struct musb_hcd_link *) hcd->hcd_priv; Daniel>

Re: [PATCH v3 06/11] usb: musb: factor out hcd initalization

2013-04-10 Thread Daniel Mack
On 10.04.2013 20:54, Peter Korsgaard wrote: >> "Daniel" == Daniel Mack writes: > > Daniel> The musb struct is currently allocated along with the hcd, which > makes > Daniel> it difficult to build a driver that only acts as gadget device. > > Daniel> Fix this by allocating musb directly,

Re: [PATCH v3 06/11] usb: musb: factor out hcd initalization

2013-04-10 Thread Peter Korsgaard
> "Daniel" == Daniel Mack writes: Daniel> The musb struct is currently allocated along with the hcd, which makes Daniel> it difficult to build a driver that only acts as gadget device. Daniel> Fix this by allocating musb directly, and keep the hcd around as Daniel> a pointer in the musb

[PATCH v3 06/11] usb: musb: factor out hcd initalization

2013-04-10 Thread Daniel Mack
The musb struct is currently allocated along with the hcd, which makes it difficult to build a driver that only acts as gadget device. Fix this by allocating musb directly, and keep the hcd around as a pointer in the musb struct. struct hc_driver musb_hc_driver can now also be static to musb_host