Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-05 Thread Bernd Krumboeck
Hi Marc! Am 2012-12-04 22:45, schrieb Marc Kleine-Budde: + +/* create a URB, and a buffer for it */ +urb = usb_alloc_urb(0, GFP_KERNEL); +if (!urb) { +netdev_err(netdev, "No memory left for URBs\n"); +return -ENOMEM; who will free the already al

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-05 Thread Bernd Krumboeck
Hi Mark! Am 2012-12-05 22:40, schrieb Marc Kleine-Budde: On 12/05/2012 06:36 PM, Bernd Krumboeck wrote: Hi Marc! +default: +netdev_info(netdev, "Rx URB aborted (%d)\n", + urb->status); +goto resubmit_urb; +} + +while (pos < urb->actual_length) { +

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-05 Thread Marc Kleine-Budde
On 12/05/2012 06:36 PM, Bernd Krumboeck wrote: > Hi Marc! > > >>> +default: >>> +netdev_info(netdev, "Rx URB aborted (%d)\n", >>> + urb->status); >>> +goto resubmit_urb; >>> +} >>> + >>> +while (pos < urb->actual_length) { >>> +struct usb_8dev_rx_ms

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-05 Thread Bernd Krumboeck
Hi Marc! +default: +netdev_info(netdev, "Rx URB aborted (%d)\n", + urb->status); +goto resubmit_urb; +} + +while (pos < urb->actual_length) { +struct usb_8dev_rx_msg *msg; + +if (pos + sizeof(struct usb_8dev_rx_msg) > urb->actual_length) {

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-04 Thread Wolfgang Grandegger
On 12/04/2012 11:20 PM, Bernd Krumboeck wrote: > Hi Wolfgang! > > > Am 2012-12-04 21:44, schrieb Wolfgang Grandegger: >> On 12/04/2012 09:44 PM, krumbo...@universalnet.at wrote: >>> Add device driver for USB2CAN interface from "8 devices" >>> (http://www.8devices.com). >>> >>> Signed-off-by: Bern

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-04 Thread Marc Kleine-Budde
On 12/04/2012 09:44 PM, krumbo...@universalnet.at wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). Please use git send-email to send patches, your mailer does strange things. > > Signed-off-by: Bernd Krumboeck > --- > drivers/net/can/usb/Kconfig

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-04 Thread Bernd Krumboeck
Hi Wolfgang! Am 2012-12-04 21:44, schrieb Wolfgang Grandegger: On 12/04/2012 09:44 PM, krumbo...@universalnet.at wrote: Add device driver for USB2CAN interface from "8 devices" (http://www.8devices.com). Signed-off-by: Bernd Krumboeck --- drivers/net/can/usb/Kconfig|6 + drivers/n

Re: [PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-04 Thread Wolfgang Grandegger
On 12/04/2012 09:44 PM, krumbo...@universalnet.at wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). > > Signed-off-by: Bernd Krumboeck > --- > drivers/net/can/usb/Kconfig|6 + > drivers/net/can/usb/Makefile |1 + > drivers/net/can/usb/us

[PATCH v3] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-04 Thread krumbo...@universalnet.at
Add device driver for USB2CAN interface from "8 devices" (http://www.8devices.com). Signed-off-by: Bernd Krumboeck --- drivers/net/can/usb/Kconfig|6 + drivers/net/can/usb/Makefile |1 + drivers/net/can/usb/usb_8dev.c | 1093 3 files chang