Re: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-19 Thread Marc Kleine-Budde
On 09/19/2012 03:11 AM, Richard Zhao wrote: > On Mon, Sep 17, 2012 at 01:06:21PM +0300, Alexander Shishkin wrote: >> Richard Zhao writes: >> >>> Signed-off-by: Richard Zhao >>> Acked-by: Felipe Balbi >> >> Felipe said, >> >>> if you add a commit log you can add my: >>> >>> Acked-by: Felipe Balb

Re: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-18 Thread Richard Zhao
On Mon, Sep 17, 2012 at 01:06:21PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > Signed-off-by: Richard Zhao > > Acked-by: Felipe Balbi > > Felipe said, > > > if you add a commit log you can add my: > > > > Acked-by: Felipe Balbi > > but the commit message is still totally

RE: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Chen Peter-B29397
> > > The purpose for this patch is to have set_peripheral implementation, > > but in current chipidea code, we don't need to know gadget at all, > > as when id switch occurs, the core code know its role (device or host) > > very well, and will call related stop/start function. > > > > We have a

RE: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Alexander Shishkin
Chen Peter-B29397 writes: > The purpose for this patch is to have set_peripheral implementation, > but in current chipidea code, we don't need to know gadget at all, > as when id switch occurs, the core code know its role (device or host) > very well, and will call related stop/start function. >

RE: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Chen Peter-B29397
The purpose for this patch is to have set_peripheral implementation, but in current chipidea code, we don't need to know gadget at all, as when id switch occurs, the core code know its role (device or host) very well, and will call related stop/start function. We have already many code bind struc

Re: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Alexander Shishkin
Richard Zhao writes: > Signed-off-by: Richard Zhao > Acked-by: Felipe Balbi Felipe said, > if you add a commit log you can add my: > > Acked-by: Felipe Balbi but the commit message is still totally missing. I would like to ask you to pay attention to the commit messages in the patches tha

[PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Richard Zhao
Signed-off-by: Richard Zhao Acked-by: Felipe Balbi --- Changes from v2: - assign host/gadget in mxs_phy_set_host/mxs_phy_set_peripheral drivers/usb/otg/mxs-phy.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy