Re: [PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-26 Thread Sergei Shtylyov
Hello. On 05/24/2014 11:22 AM, Daniel Mack wrote: I I'd say it's not supposed to. I just wanted the bit to be 0 when writing back the CSR. You failed to achieve that since you forgot ~; you're clearing all bits but this one. Ouch, totally missed that, thanks! And I've missed CSR0

Re: [PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-24 Thread Daniel Mack
On 05/23/2014 11:15 PM, Sergei Shtylyov wrote: > On 05/23/2014 04:57 PM, Daniel Mack wrote: >> I I'd say it's not supposed to. I just wanted the bit to be 0 when >> writing back the CSR. > >You failed to achieve that since you forgot ~; you're clearing all bits > but > this one. Ouch, total

Re: [PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-23 Thread Sergei Shtylyov
Hello. On 05/23/2014 04:57 PM, Daniel Mack wrote: The datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_CSR0_TXPKTRDY is set as well. Also, clear the MUSB_TXCSR_H_RXSTALL which drivers are not supposed to write, I'd say "to set" ISO "to write" -- the bit still is clearabl

Re: [PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-23 Thread Daniel Mack
Hi Sergei, On 05/23/2014 02:52 PM, Sergei Shtylyov wrote: > On 05/23/2014 01:31 PM, Daniel Mack wrote: > >> The datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when >> MUSB_CSR0_TXPKTRDY is set as well. Also, clear the MUSB_TXCSR_H_RXSTALL >> which drivers are not supposed to write, > >

Re: [PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-23 Thread Sergei Shtylyov
Hello. On 05/23/2014 01:31 PM, Daniel Mack wrote: The datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_CSR0_TXPKTRDY is set as well. Also, clear the MUSB_TXCSR_H_RXSTALL which drivers are not supposed to write, I'd say "to set" ISO "to write" -- the bit still is clearable b

[PATCH v2 4/6] usb: musb: fix bit masks for CSR in musb_h_tx_flush_fifo()

2014-05-23 Thread Daniel Mack
The datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_CSR0_TXPKTRDY is set as well. Also, clear the MUSB_TXCSR_H_RXSTALL which drivers are not supposed to write, according to the docs. With this patch applied, the warning in this function does no longer kick in when an USB soundcard