Re: [PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-07 Thread Peter Chen
> > I will add defines und use them. > > > > + max &= 0x7ff; /* bit 0~10 */ > > > > Useless line? > > Not intended. I will have to change the capability > setting of the qh to use max instead of mEp->ep.maxpacket. mult = (unsigned char)(1 + ((max >> 11) & 0x03));

Re: [PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-07 Thread Michael Grzeschik
On Mon, Mar 04, 2013 at 11:26:07AM +0800, Peter Chen wrote: > On Fri, Mar 01, 2013 at 03:42:24PM +0100, Michael Grzeschik wrote: > > The implementation is derived from the fsl_udc_core code in > > fsl_ep_enable and makes basic iso handling possible. > > > > Signed-off-by: Michael Grzeschik > > Si

Re: [PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-03 Thread Peter Chen
On Fri, Mar 01, 2013 at 03:42:24PM +0100, Michael Grzeschik wrote: > The implementation is derived from the fsl_udc_core code in > fsl_ep_enable and makes basic iso handling possible. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > Changes since v1: > - fixed cod

[PATCH v2 2/5] usb: chipidea: udc: configure iso endpoints

2013-03-01 Thread Michael Grzeschik
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde --- Changes since v1: - fixed coding style issues mentioned by Sergei drivers/usb/chipidea/udc.c | 12 ++