Re: [PATCH v2 2/4] cdc-acm: fix possible invalid access when processing notification

2017-03-20 Thread Oliver Neukum
Am Samstag, den 18.03.2017, 19:52 +0100 schrieb Tobias Herzog: > Notifications may only be 8 bytes so long. Accessing the 9th and > 10th byte of unimplemented/unknown notifications may be insecure. > Also check the length of known notifications before accessing anything > behind the 8th byte. > T

Re: [PATCH v2 2/4] cdc-acm: fix possible invalid access when processing notification

2017-03-19 Thread Sergei Shtylyov
On 3/18/2017 9:52 PM, Tobias Herzog wrote: Notifications may only be 8 bytes so long. Accessing the 9th and s/so//. "So long and thanks for all the fish!" :-) 10th byte of unimplemented/unknown notifications may be insecure. Also check the length of known notifications before accessing

[PATCH v2 2/4] cdc-acm: fix possible invalid access when processing notification

2017-03-18 Thread Tobias Herzog
Notifications may only be 8 bytes so long. Accessing the 9th and 10th byte of unimplemented/unknown notifications may be insecure. Also check the length of known notifications before accessing anything behind the 8th byte. Signed-off-by: Tobias Herzog --- drivers/usb/class/cdc-acm.c | 11 +++