Re: [PATCH v2 2/4] Staging: rtl8723bs: Change names to conform to the kernel code

2018-01-17 Thread Shreeya Patel
On Wed, 2018-01-17 at 14:59 +0100, Greg KH wrote: > On Wed, Jan 17, 2018 at 12:27:40AM +0530, Shreeya Patel wrote: > > > > Change names of some variables and functions to conform > > to the kernel coding style. > That's really vague, say exactly what you did here.  And don't do all > functions/var

Re: [PATCH v2 2/4] Staging: rtl8723bs: Change names to conform to the kernel code

2018-01-17 Thread Greg KH
On Wed, Jan 17, 2018 at 12:27:40AM +0530, Shreeya Patel wrote: > Change names of some variables and functions to conform > to the kernel coding style. That's really vague, say exactly what you did here. And don't do all functions/variables at once, that's a pain to review, would you want to revie

[PATCH v2 2/4] Staging: rtl8723bs: Change names to conform to the kernel code

2018-01-16 Thread Shreeya Patel
Change names of some variables and functions to conform to the kernel coding style. Signed-off-by: Shreeya Patel --- Changes in v2 -Rebase and resend. drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++ 1 file changed, 357 insertions(+), 357 deletions(-) diff --g