RE: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-29 Thread Kamil Debski
Hi, > From: Tomasz Figa [mailto:tomasz.f...@gmail.com] > Sent: Monday, October 28, 2013 9:00 PM > > Hi Kamil, > > On Monday 28 of October 2013 14:52:19 Kamil Debski wrote: > > Hi Kishon, > > > > Thank you for your review! I will answer your comments below. > [snip] > > > > + > > > > + swit

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-29 Thread Kishon Vijay Abraham I
Hi, On Monday 28 October 2013 07:22 PM, Kamil Debski wrote: > Hi Kishon, > > Thank you for your review! I will answer your comments below. > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] >> Sent: Friday, October 25, 2013 5:40 PM >> >> Hi, >> >> On Friday 25 October 2013 07:45 PM, Kamil

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-28 Thread Tomasz Figa
Hi Kamil, On Monday 28 of October 2013 14:52:19 Kamil Debski wrote: > Hi Kishon, > > Thank you for your review! I will answer your comments below. [snip] > > > + > > > + switch (drv->cfg->cpu) { > > > + case TYPE_EXYNOS4210: > > > > > + case TYPE_EXYNOS4212: > > Lets not add such cpu checks insi

RE: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-28 Thread Kamil Debski
Hi Kumar Gala, > From: Kumar Gala [mailto:ga...@codeaurora.org] > Sent: Friday, October 25, 2013 11:36 PM > > On Oct 25, 2013, at 9:15 AM, Kamil Debski wrote: > > > Add a new driver for the Exynos USB PHY. The new driver uses the > > generic PHY framework. The driver includes support for the Exy

RE: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-28 Thread Kamil Debski
Hi Kishon, Thank you for your review! I will answer your comments below. > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Friday, October 25, 2013 5:40 PM > > Hi, > > On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-25 Thread Kumar Gala
On Oct 25, 2013, at 9:15 AM, Kamil Debski wrote: > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --- > .../devic

Re: [PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-25 Thread Kishon Vijay Abraham I
Hi, On Friday 25 October 2013 07:45 PM, Kamil Debski wrote: > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --- >

[PATCH v2 1/5] phy: Add new Exynos USB PHY driver

2013-10-25 Thread Kamil Debski
Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- .../devicetree/bindings/phy/samsung-usbphy.txt | 51 +++ drivers/phy/