Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-03 Thread Johan Hovold
On Wed, Sep 03, 2014 at 04:39:48PM +0300, Octavian Purdila wrote: > On Tue, Sep 2, 2014 at 6:23 PM, Johan Hovold wrote: > > That should be possible using the regmap bus read and write operations. > > I took a closer look on the regmap bus read/write operations and I > think they are not fit for

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-03 Thread Octavian Purdila
On Tue, Sep 2, 2014 at 6:23 PM, Johan Hovold wrote: > On Tue, Sep 02, 2014 at 11:45:55AM +0300, Octavian Purdila wrote: >> On Tue, Sep 2, 2014 at 11:00 AM, Lee Jones wrote: >> > On Mon, 01 Sep 2014, Johan Hovold wrote: > >> >> I haven't looked at the details of the protocol for the device in >> >

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-02 Thread Johan Hovold
On Tue, Sep 02, 2014 at 11:45:55AM +0300, Octavian Purdila wrote: > On Tue, Sep 2, 2014 at 11:00 AM, Lee Jones wrote: > > On Mon, 01 Sep 2014, Johan Hovold wrote: > >> I haven't looked at the details of the protocol for the device in > >> question, but it might even be possible to use regmap here

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-02 Thread Johan Hovold
On Tue, Sep 02, 2014 at 09:00:10AM +0100, Lee Jones wrote: > On Mon, 01 Sep 2014, Johan Hovold wrote: > > No, no. USB is not a function of the MFD device, it's the transport. > > Thus there should be no USB MFD-cell. No subdriver can work without it. > > > > And the USB id belongs in the MFD-driv

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-02 Thread Octavian Purdila
On Tue, Sep 2, 2014 at 11:00 AM, Lee Jones wrote: > On Mon, 01 Sep 2014, Johan Hovold wrote: >> On Mon, Sep 01, 2014 at 07:22:39PM +0300, Octavian Purdila wrote: >> > On Mon, Sep 1, 2014 at 6:46 PM, Lee Jones wrote: >> > > On Mon, 01 Sep 2014, Octavian Purdila wrote: >> > > >> > >> On Mon, Sep 1,

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-02 Thread Lee Jones
On Mon, 01 Sep 2014, Johan Hovold wrote: > On Mon, Sep 01, 2014 at 07:22:39PM +0300, Octavian Purdila wrote: > > On Mon, Sep 1, 2014 at 6:46 PM, Lee Jones wrote: > > > On Mon, 01 Sep 2014, Octavian Purdila wrote: > > > > > >> On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones wrote: > > >> > On Mon, 01 Se

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Johan Hovold
On Mon, Sep 01, 2014 at 07:22:39PM +0300, Octavian Purdila wrote: > On Mon, Sep 1, 2014 at 6:46 PM, Lee Jones wrote: > > On Mon, 01 Sep 2014, Octavian Purdila wrote: > > > >> On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones wrote: > >> > On Mon, 01 Sep 2014, Octavian Purdila wrote: > >> >> On Mon, Sep 1

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Octavian Purdila
On Mon, Sep 1, 2014 at 6:46 PM, Lee Jones wrote: > On Mon, 01 Sep 2014, Octavian Purdila wrote: > >> On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones wrote: >> > On Mon, 01 Sep 2014, Octavian Purdila wrote: >> > >> >> On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones wrote: >> >> > On Mon, 01 Sep 2014, Octavi

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Mon, 01 Sep 2014, Octavian Purdila wrote: > On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones wrote: > > On Mon, 01 Sep 2014, Octavian Purdila wrote: > > > >> On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones wrote: > >> > On Mon, 01 Sep 2014, Octavian Purdila wrote: > >> > > >> >> On Mon, Sep 1, 2014 at 11

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Octavian Purdila
On Mon, Sep 1, 2014 at 2:39 PM, Lee Jones wrote: > On Mon, 01 Sep 2014, Octavian Purdila wrote: > >> On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones wrote: >> > On Mon, 01 Sep 2014, Octavian Purdila wrote: >> > >> >> On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones wrote: >> >> > On Sat, 30 Aug 2014, Octav

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Mon, 01 Sep 2014, Octavian Purdila wrote: > On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones wrote: > > On Mon, 01 Sep 2014, Octavian Purdila wrote: > > > >> On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones wrote: > >> > On Sat, 30 Aug 2014, Octavian Purdila wrote: > >> > > >> >> This patch implements th

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Octavian Purdila
On Mon, Sep 1, 2014 at 12:51 PM, Lee Jones wrote: > On Mon, 01 Sep 2014, Octavian Purdila wrote: > >> On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones wrote: >> > On Sat, 30 Aug 2014, Octavian Purdila wrote: >> > >> >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO >> >> Master Adapt

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Mon, 01 Sep 2014, Octavian Purdila wrote: > On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones wrote: > > On Sat, 30 Aug 2014, Octavian Purdila wrote: > > > >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > >> Master Adapter DLN-2. Details about the device can be found here: > >>

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Octavian Purdila
On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones wrote: > On Sat, 30 Aug 2014, Octavian Purdila wrote: > >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO >> Master Adapter DLN-2. Details about the device can be found here: >> >> https://www.diolan.com/i2c/i2c_interface.html. >> >> In

Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-01 Thread Lee Jones
On Sat, 30 Aug 2014, Octavian Purdila wrote: > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > Master Adapter DLN-2. Details about the device can be found here: > > https://www.diolan.com/i2c/i2c_interface.html. > > Information about the USB protocol can be found in the Progr

[PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

2014-08-29 Thread Octavian Purdila
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see section 1.7. Because th