Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 03:34:08PM +0300, Octavian Purdila wrote: > I can follow-up with a v3 3 patch series: first for the fix, second > for the OOM & error path cleanup, third for devm conversion. I'd include the error-path clean up bit in the devres conversion as that is what it's really all a

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Octavian Purdila
On Wed, Sep 24, 2014 at 3:26 PM, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote: >> On Wed, 24 Sep 2014, Johan Hovold wrote: >> >> > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: >> > > On Mon, 22 Sep 2014, Octavian Purdila wrote: >> > > >> > > > Curre

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 01:00:02PM +0100, Lee Jones wrote: > On Wed, 24 Sep 2014, Johan Hovold wrote: > > > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > > > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > > > > > Currently the I/O buffer is allocated part of the device status >

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
On Wed, 24 Sep 2014, Johan Hovold wrote: > On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > > > Currently the I/O buffer is allocated part of the device status > > > structure, potentially sharing the same cache line with other memb

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Johan Hovold
On Wed, Sep 24, 2014 at 11:12:06AM +0100, Lee Jones wrote: > On Mon, 22 Sep 2014, Octavian Purdila wrote: > > > Currently the I/O buffer is allocated part of the device status > > structure, potentially sharing the same cache line with other members > > in this structure. > > > > Allocate the buf

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-24 Thread Lee Jones
On Mon, 22 Sep 2014, Octavian Purdila wrote: > Currently the I/O buffer is allocated part of the device status > structure, potentially sharing the same cache line with other members > in this structure. > > Allocate the buffer separately, to avoid the I/O operations corrupting > the device statu

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-23 Thread Johan Hovold
On Mon, Sep 22, 2014 at 10:39:18PM +0300, Octavian Purdila wrote: > Currently the I/O buffer is allocated part of the device status > structure, potentially sharing the same cache line with other members > in this structure. > > Allocate the buffer separately, to avoid the I/O operations corruptin

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-23 Thread Johan Hovold
On Tue, Sep 23, 2014 at 09:35:41AM +0200, Johan Hovold wrote: > On Mon, Sep 22, 2014 at 10:39:18PM +0300, Octavian Purdila wrote: > > Currently the I/O buffer is allocated part of the device status > > structure, potentially sharing the same cache line with other members > > in this structure. > >

Re: [PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-23 Thread Johan Hovold
On Mon, Sep 22, 2014 at 10:39:18PM +0300, Octavian Purdila wrote: > Currently the I/O buffer is allocated part of the device status > structure, potentially sharing the same cache line with other members > in this structure. > > Allocate the buffer separately, to avoid the I/O operations corruptin

[PATCH v2 1/2] mfd: viperboard: allocate I/O buffer separately

2014-09-22 Thread Octavian Purdila
Currently the I/O buffer is allocated part of the device status structure, potentially sharing the same cache line with other members in this structure. Allocate the buffer separately, to avoid the I/O operations corrupting the device status structure due to cache line sharing. Compiled tested on