Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 12:44:40PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: > >> >> Richard Zhao wr

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-29 Thread Alexander Shishkin
Richard Zhao writes: > On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote: >> Richard Zhao writes: >> >> > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: >> >> Richard Zhao writes: >> >> >> >> > States in gadget are not needed any more, set it to zero. >>

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > States in gadget are not needed any more, set it to zero. > >> > >> It's generally a good p

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-29 Thread Alexander Shishkin
Richard Zhao writes: > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: >> Richard Zhao writes: >> >> > States in gadget are not needed any more, set it to zero. >> >> It's generally a good practice to mention in the commit message what is >> it that you are fixing with this

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > States in gadget are not needed any more, set it to zero. > > It's generally a good practice to mention in the commit message what is > it that you are fixing with this patch. It fixes the following

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-28 Thread Alexander Shishkin
Richard Zhao writes: > States in gadget are not needed any more, set it to zero. It's generally a good practice to mention in the commit message what is it that you are fixing with this patch. > Signed-off-by: Richard Zhao > --- > drivers/usb/chipidea/udc.c |1 + > 1 file changed, 1 inser

[PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-28 Thread Richard Zhao
States in gadget are not needed any more, set it to zero. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/udc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index c7a032a..9fb6394 100644 --- a/drivers/usb/chipidea/udc.c +++ b