RE: [PATCH v2 01/11] usbip: exporting devices

2015-04-23 Thread fx IWATA NOBUO
Hi Valentina, > * I noticed in some places you've used labels such as err0 and err1. > Please replace them with something more relevant to their > functionality, > such as what you're cleaning up after. There are examples of this > both in > USB/IP code and throughout the kernel. I will fix all

Re: [PATCH v2 01/11] usbip: exporting devices

2015-04-21 Thread Valentina Manea
Hi, I looked around your patch and tested it and looks good. However, I do have 2 nit-picks: * I noticed in some places you've used labels such as err0 and err1. Please replace them with something more relevant to their functionality, such as what you're cleaning up after. There are examples of t

[PATCH v2 01/11] usbip: exporting devices

2015-04-14 Thread Nobuo Iwata
USB/IP supports a function to import USB devices from application-side machine by attach command. The usage is as following. dev:# (Physically attach your USB device.) dev:# insmod usbip-core.ko and usbip-host.ko dev:# usbipd -D // Start usbip daemon. dev:# usbip list -l // List local USB devices