Re: [PATCH v2] wusb: use correct format characters

2019-02-28 Thread Jon Flatley
On Thu, Feb 28, 2019 at 3:05 PM Joe Perches wrote: > > On Thu, 2019-02-28 at 14:23 -0800, Jon Flatley wrote: > > Thanks for the patch and comments. > > > > On Thu, Feb 28, 2019 at 1:53 PM Joe Perches wrote: > > > On Thu, 2019-02-28 at 12:24 +, Louis Taylor wrote: > > > > When compiling with -

Re: [PATCH v2] wusb: use correct format characters

2019-02-28 Thread Joe Perches
On Thu, 2019-02-28 at 14:23 -0800, Jon Flatley wrote: > Thanks for the patch and comments. > > On Thu, Feb 28, 2019 at 1:53 PM Joe Perches wrote: > > On Thu, 2019-02-28 at 12:24 +, Louis Taylor wrote: > > > When compiling with -Wformat, clang warns: > > > ./include/linux/usb/wusb.h:245:5: war

Re: [PATCH v2] wusb: use correct format characters

2019-02-28 Thread Jon Flatley
Thanks for the patch and comments. On Thu, Feb 28, 2019 at 1:53 PM Joe Perches wrote: > > On Thu, 2019-02-28 at 12:24 +, Louis Taylor wrote: > > When compiling with -Wformat, clang warns: > > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > > 'unsigned short' but the argumen

Re: [PATCH v2] wusb: use correct format characters

2019-02-28 Thread Joe Perches
On Thu, 2019-02-28 at 12:24 +, Louis Taylor wrote: > When compiling with -Wformat, clang warns: > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') > [-Wformat] > ckhdid->data[0], ckhdid->data[1], > ^~~~

Re: [PATCH v2] wusb: use correct format characters

2019-02-28 Thread Nick Desaulniers
On Thu, Feb 28, 2019 at 4:28 AM Louis Taylor wrote: > > When compiling with -Wformat, clang warns: > > ./include/linux/usb/wusb.h:245:5: warning: format specifies type > 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') We should probably update Documentation/core-api/printk-f

[PATCH v2] wusb: use correct format characters

2019-02-28 Thread Louis Taylor
When compiling with -Wformat, clang warns: ./include/linux/usb/wusb.h:245:5: warning: format specifies type 'unsigned short' but the argument has type 'u8' (aka 'unsigned char') [-Wformat] ckhdid->data[0], ckhdid->data[1], ^~~ ckhdid->data is unconditionally defined as `u8 data[1