On 12/03/2012 09:15 PM, Wolfgang Grandegger wrote:
> On 12/03/2012 09:32 PM, krumbo...@universalnet.at wrote:
>> Hi Wolfgang!
>>
>>>
>>> And please also drop the remaining sysfs files for firmware and
>>> hardware. I thinks it's enough that the versions are printed when the
>>> device is probed.
>>
On 12/03/2012 09:42 PM, krumbo...@universalnet.at wrote:
> Hi Marc!
>
>
>>> +/* Send open command to device */
>>> +static int usb_8dev_cmd_open(struct usb_8dev *dev)
>>> +{
>>> +struct can_bittiming *bt = &dev->can.bittiming;
>>> +struct usb_8dev_cmd_msg outmsg;
>>> +struct usb_8dev_
On 12/03/2012 09:32 PM, krumbo...@universalnet.at wrote:
> Hi Wolfgang!
>
>>
>> And please also drop the remaining sysfs files for firmware and
>> hardware. I thinks it's enough that the versions are printed when the
>> device is probed.
>
> Systemadministrators often use versions for configurati
Hi Marc!
+/* Send open command to device */
+static int usb_8dev_cmd_open(struct usb_8dev *dev)
+{
+struct can_bittiming *bt = &dev->can.bittiming;
+struct usb_8dev_cmd_msg outmsg;
+struct usb_8dev_cmd_msg inmsg;
+u32 flags = 0;
+u32 beflags;
+u16 bebrp;
+u32 ctrlmod
Hi Wolfgang!
And please also drop the remaining sysfs files for firmware and
hardware. I thinks it's enough that the versions are printed when the
device is probed.
Systemadministrators often use versions for configuration scripts.
If you insist I will remove.
+/*
+ * CAN driver for UAB "8
On 12/03/2012 01:50 AM, krumbo...@universalnet.at wrote:
> Add device driver for USB2CAN interface from "8 devices"
> (http://www.8devices.com).
>
> Signed-off-by: Bernd Krumboeck
Please send your patch with git send-email, as with this one all tabs
are converted to spaces.
> ---
> drivers/net
Hi, at a closer look I see a few more issues:
Please use s/dev_warn(netdev->dev.parent,/netdev_warn(/ for dev_warn and
friends.
You can drop the do_set_bittiming callback if it's not needed. There is
no need for a dummy function, IIRC.
And please also drop the remaining sysfs files for firmware
Add device driver for USB2CAN interface from "8 devices"
(http://www.8devices.com).
Signed-off-by: Bernd Krumboeck
---
drivers/net/can/usb/Kconfig|6 +
drivers/net/can/usb/Makefile |1 +
drivers/net/can/usb/usb_8dev.c | 1098
3 files chang
