On Wed, 23 Jul 2014 09:21:29 -0700
Greg KH wrote:
> On Wed, Jul 23, 2014 at 05:03:14PM +0100, One Thousand Gnomes wrote:
> > > + if (gpiochip_remove(&spriv->gpio->gpio_chip))
> > > + dev_err(&serial->interface->dev, "unable to remove
> > > gpio_chip?\n");
> > > +
On Wed, Jul 23, 2014 at 05:03:14PM +0100, One Thousand Gnomes wrote:
> > + if (gpiochip_remove(&spriv->gpio->gpio_chip))
> > + dev_err(&serial->interface->dev, "unable to remove
> > gpio_chip?\n");
> > + kfree(spriv->gpio);
> > + }
> > +#endif
> > kfree(
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -28,6 +28,9 @@
> #include
> #include
> #include
> +#ifdef CONFIG_USB_SERIAL_PL2303_GPIO
> +#include
> +#endif
> #include "pl2303.h"
Just include the file anyway it does no harm
>
>
> @@ -143,9 +146,27 @@ stru
2014-07-20 8:38 GMT+02:00 Wang YanQing:
> PL2303HX has two GPIOs, this patch add interface for it.
checkpatch.pl shows 2 errors:
ERROR: space required before the open parenthesis '('
#218: FILE: drivers/usb/serial/pl2303.c:309:
+ if(pl2303_vendor_read(gpio->serial, 0x0081, buf) < 1)
ERROR: that
PL2303HX has two GPIOs, this patch add interface for it.
Signed-off-by: Wang YanQing
---
Changes v1-v2:
1:drop gpio-pl2303.c and relation stuff
2:hang gpio stuff off of pl2303.c
drivers/usb/serial/Kconfig | 7 ++
drivers/usb/serial/pl2303.c | 153 ++
