Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Ivan T. Ivanov
On Thu, 2014-03-27 at 12:15 -0500, Felipe Balbi wrote: > > I mean, -rc8 is out, if you fix your patches up right now, how much > testing can you do in the next couple days ? Patches need to soak in > linux-next for a while. Even if Greg would accept a pull request, I'm > not sure I'd feel comforta

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Felipe Balbi
On Thu, Mar 27, 2014 at 06:16:15PM +0200, Ivan T. Ivanov wrote: > On Thu, 2014-03-27 at 09:58 -0500, Felipe Balbi wrote: > > On Thu, Mar 27, 2014 at 04:03:08PM +0200, Ivan T. Ivanov wrote: > > > > > > Hi, > > > > > > On Wed, 2014-03-26 at 12:15 -0500, Felipe Balbi wrote: > > > > > > ps: can you

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Ivan T. Ivanov
On Thu, 2014-03-27 at 09:58 -0500, Felipe Balbi wrote: > On Thu, Mar 27, 2014 at 04:03:08PM +0200, Ivan T. Ivanov wrote: > > > > Hi, > > > > On Wed, 2014-03-26 at 12:15 -0500, Felipe Balbi wrote: > > > > > ps: can you guys, please, just send your dwc3 glue layer ? :-) > > > > > > > > Ivan Ivano

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Felipe Balbi
On Thu, Mar 27, 2014 at 04:03:08PM +0200, Ivan T. Ivanov wrote: > > Hi, > > On Wed, 2014-03-26 at 12:15 -0500, Felipe Balbi wrote: > > > > ps: can you guys, please, just send your dwc3 glue layer ? :-) > > > > > > Ivan Ivanov (cc'ed) had sent a number of patches for our "dwc3-msm" > > > layer t

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-27 Thread Ivan T. Ivanov
Hi, On Wed, 2014-03-26 at 12:15 -0500, Felipe Balbi wrote: > > > ps: can you guys, please, just send your dwc3 glue layer ? :-) > > > > Ivan Ivanov (cc'ed) had sent a number of patches for our "dwc3-msm" > > layer to the list for review, but I think they were still held up in the > > feedback p

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-26 Thread Felipe Balbi
hi, On Wed, Mar 26, 2014 at 10:13:24AM -0700, Jack Pham wrote: > On Tue, Mar 25, 2014 at 08:45:11PM -0500, Felipe Balbi wrote: > > > + for (num = 0; num < dwc->num_in_eps; num++) { > > > + struct dwc3_ep *dep = dwc->eps[(num << 1) | 1]; > > > > Just add a comment here stating that bit0 i

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-26 Thread Jack Pham
Hi Felipe, On Tue, Mar 25, 2014 at 08:45:11PM -0500, Felipe Balbi wrote: > > + for (num = 0; num < dwc->num_in_eps; num++) { > > + struct dwc3_ep *dep = dwc->eps[(num << 1) | 1]; > > Just add a comment here stating that bit0 is the direction bit, just so > we don't forget in the futu

Re: [PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-25 Thread Felipe Balbi
Hi, On Tue, Mar 25, 2014 at 04:11:06PM -0700, Jack Pham wrote: > Make dwc3_gadget_resize_tx_fifos() iterate only over IN > endpoints that are actually present, based on the > num_in_eps parameter. This terminates the loop so as to > prevent dereferencing a potential NULL dwc->eps[i] where > i >= (

[PATCH v2] usb: dwc3: gadget: Iterate only over valid endpoints

2014-03-25 Thread Jack Pham
Make dwc3_gadget_resize_tx_fifos() iterate only over IN endpoints that are actually present, based on the num_in_eps parameter. This terminates the loop so as to prevent dereferencing a potential NULL dwc->eps[i] where i >= (num_in_eps + num_out_eps). Signed-off-by: Jack Pham --- v2: Removed extr