Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-09-05 Thread Felipe Balbi
On Wed, Sep 03, 2014 at 11:58:26AM +0530, Pratyush Anand wrote: > On Wed, Aug 27, 2014 at 05:26:37AM +0800, Felipe Balbi wrote: > > Hi Felipe, > > > Hi, > > > > On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Tuesday,

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-09-02 Thread Pratyush Anand
On Wed, Aug 27, 2014 at 05:26:37AM +0800, Felipe Balbi wrote: Hi Felipe, > Hi, > > On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, August 26, 2014 1:42 PM > > > > > > On Fri, Aug 22, 2014 at 04:56:46PM -0500, Fe

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-26 Thread Felipe Balbi
Hi, On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, August 26, 2014 1:42 PM > > > > On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: > > ... > > > yeah, it took longer than expected (been busy lately),

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-26 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 26, 2014 1:42 PM > > On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: ... > yeah, it took longer than expected (been busy lately), but here's an > example trace with all trace points enabled: > > # tracer: nop > # >

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-26 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: > > > diff --git a/drivers/usb/dwc3/debug.c b/drivers/usb/dwc3/debug.c > > > new file mode 100644 > > > index 000..6d01e0c > > > --- /dev/null > > > +++ b/drivers/usb/dwc3/debug.c > > > @@ -0,0 +1,33 @@ > > > +/** > > > + * debu

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-22 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 09:26:55PM +, Paul Zimmerman wrote: > > diff --git a/drivers/usb/dwc3/debug.c b/drivers/usb/dwc3/debug.c > > new file mode 100644 > > index 000..6d01e0c > > --- /dev/null > > +++ b/drivers/usb/dwc3/debug.c > > @@ -0,0 +1,33 @@ > > +/** > > + * debug.c - DesignWa

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-22 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, August 22, 2014 1:47 PM > > On Tue, Aug 19, 2014 at 11:36:05PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi > > Date: Wed, 30 Apr 2014 17:45:10 -0500 > > > diff --git a/drivers/usb/dwc3/debug.c b/drivers/usb/dwc3/debug.c > > >

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-22 Thread Felipe Balbi
Hi, On Tue, Aug 19, 2014 at 11:36:05PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, August 19, 2014 3:02 PM > > > > I didn't have time to test this yet (other than build testing), but how > > does this one look ? Now we will print cute little string

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 19, 2014 3:02 PM > > I didn't have time to test this yet (other than build testing), but how > does this one look ? Now we will print cute little strings for all > events and we still have proper link state tracking. > > 8<---

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Felipe Balbi
Hi, On Tue, Aug 19, 2014 at 08:14:11PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, August 19, 2014 1:10 PM > > > > On Tue, Aug 19, 2014 at 08:00:27PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Tuesda

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 19, 2014 1:10 PM > > On Tue, Aug 19, 2014 at 08:00:27PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, August 19, 2014 12:09 PM > > > > > > When we're debugging hard-to-reproduce an

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Felipe Balbi
On Tue, Aug 19, 2014 at 08:00:27PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, August 19, 2014 12:09 PM > > > > When we're debugging hard-to-reproduce and time-sensitive > > use cases, printk() poses too much overhead. That's when > > the kernel's t

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, August 19, 2014 12:09 PM > > When we're debugging hard-to-reproduce and time-sensitive > use cases, printk() poses too much overhead. That's when > the kernel's tracing infrastructure comes into play. > > This patch implements a few init

[PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-19 Thread Felipe Balbi
When we're debugging hard-to-reproduce and time-sensitive use cases, printk() poses too much overhead. That's when the kernel's tracing infrastructure comes into play. This patch implements a few initial tracepoints for the dwc3 driver. More traces can be added as necessary in order to ease the ta