Re: [PATCH v2] usb/uhci: Add support for Aspeed BMC SoCs

2017-05-24 Thread Alan Stern
On Thu, 25 May 2017, Benjamin Herrenschmidt wrote: > On Wed, 2017-05-24 at 13:58 -0400, Alan Stern wrote: > > Does this new symbol really add anything?  I mean, wouldn't it be just > > as good to use CONFIG_ARCH_ASPEED instead?  It gets used in only one > > place. > > I wanted to split them in

Re: [PATCH v2] usb/uhci: Add support for Aspeed BMC SoCs

2017-05-24 Thread Benjamin Herrenschmidt
On Wed, 2017-05-24 at 13:58 -0400, Alan Stern wrote: > Does this new symbol really add anything?  I mean, wouldn't it be just > as good to use CONFIG_ARCH_ASPEED instead?  It gets used in only one > place. I wanted to split them in case future designs (or different SoC families from Aspeed) do t

Re: [PATCH v2] usb/uhci: Add support for Aspeed BMC SoCs

2017-05-24 Thread Alan Stern
On Tue, 23 May 2017, Benjamin Herrenschmidt wrote: > The Aspeed 2400/2500 families have a variant of UHCI which requires > some quirks to the driver to work: > > - The register offsets are different. We add a remapping helper. > > - All accesses have to be done via 32-bit loads and stores. We

Re: [PATCH v2] usb/uhci: Add support for Aspeed BMC SoCs

2017-05-23 Thread Greg KH
On Tue, May 23, 2017 at 10:44:05AM +1000, Benjamin Herrenschmidt wrote: > The Aspeed 2400/2500 families have a variant of UHCI which requires > some quirks to the driver to work: > > - The register offsets are different. We add a remapping helper. > > - All accesses have to be done via 32-bit l

[PATCH v2] usb/uhci: Add support for Aspeed BMC SoCs

2017-05-22 Thread Benjamin Herrenschmidt
The Aspeed 2400/2500 families have a variant of UHCI which requires some quirks to the driver to work: - The register offsets are different. We add a remapping helper. - All accesses have to be done via 32-bit loads and stores. We force all accessors to use readl/writel. This is of no conseq