Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-19 Thread Linus Walleij
On Mon, Mar 9, 2015 at 8:10 PM, David Cohen wrote: > But at least on ACPI case, GPIO API blocks the ability to create > children platform devices that require GPIO as platform data, despite > we've many drivers on upstream that expect this behavior: e.g. extcon-gpio.c > > Are we considering those

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-16 Thread David Cohen
On Mon, Mar 16, 2015 at 09:46:00AM -0700, David Cohen wrote: > Adding Mika to CC list. Grrr :( Adding for real now. > > Br, David > > On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote: > > Hi Linus, > > > > On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: > > > On Sat, M

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-16 Thread David Cohen
Adding Mika to CC list. Br, David On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote: > Hi Linus, > > On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: > > On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: > > > On Fri, Feb 20, 2015 at 8:17 PM, David Cohen > > >

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-09 Thread David Cohen
Hi Linus, On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: > On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: > > On Fri, Feb 20, 2015 at 8:17 PM, David Cohen > > wrote: > > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > > > > >> I would put this ad

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-09 Thread Felipe Balbi
On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: > On Fri, Feb 20, 2015 at 8:17 PM, David Cohen > wrote: > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > > >> I would put this adjacent to the phy driver somewhere in drivers/usb/* > >> and make the actual USB-driv

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-07 Thread Linus Walleij
On Fri, Feb 20, 2015 at 8:17 PM, David Cohen wrote: > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: >> I would put this adjacent to the phy driver somewhere in drivers/usb/* >> and make the actual USB-driver thing handle its GPIOs directly. >> But I guess David and Felipe have al

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-07 Thread Linus Walleij
On Fri, Feb 20, 2015 at 9:40 PM, David Cohen wrote: > On Fri, Feb 20, 2015 at 02:00:26PM -0600, Felipe Balbi wrote: >> On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote: >> > I'd need to lookup GPIOs via ACPI without requesting them on mfd driver >> > and then give them to children devi

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-24 Thread David Cohen
Hi, [snip] > Felipe suggested to "divide to conquer" instead of having a single > extcon driver to handle all these functions: > > - The mux functions would be controlled by a possible new pinctrl-gpio > driver (Linus, your input here would be nice :) > - The VBUS would be a fixed regulator > -

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread David Cohen
On Fri, Feb 20, 2015 at 02:00:26PM -0600, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote: > > On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: > > > On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: > > > > Hi Linus and Robert, > > > > > >

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Felipe Balbi
On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote: > On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: > > On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: > > > Hi Linus and Robert, > > > > > > CC'ing Heikki as it involves a RFC from him. > > > > > > On Fri, Feb

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread David Cohen
On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: > > Hi Linus and Robert, > > > > CC'ing Heikki as it involves a RFC from him. > > > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > > > On Fri, Feb 20, 2

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Felipe Balbi
On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote: > Hi Linus and Robert, > > CC'ing Heikki as it involves a RFC from him. > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > > On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga > > wrote: > > > Hi David, > > > > > > On 0

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread David Cohen
On Fri, Feb 20, 2015 at 08:10:34PM +0100, Paul Bolle wrote: > On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote: > > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > > As always, comments are welcome. > > > > > > Are n

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread David Cohen
On Fri, Feb 20, 2015 at 01:09:00PM -0600, Felipe Balbi wrote: > On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote: > > Hi, > > > > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > > As always, comments are welco

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread David Cohen
Hi Linus and Robert, CC'ing Heikki as it involves a RFC from him. On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga wrote: > > Hi David, > > > > On 02/19/2015 08:59 PM, David Cohen wrote: > >> Some Intel platforms have an USB OTG por

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Paul Bolle
On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote: > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > As always, comments are welcome. > > > > Are nits welcome too? > > > > > +MODULE_LICENSE("GPLv2"); > > > > You proba

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Felipe Balbi
On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote: > Hi, > > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > > As always, comments are welcome. > > > > Are nits welcome too? > > > > > +MODULE_LICENSE("GPLv2"); >

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread David Cohen
Hi, On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote: > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > > As always, comments are welcome. > > Are nits welcome too? > > > +MODULE_LICENSE("GPLv2"); > > You probably meant > MODULE_LICENSE("GPL v2") > > Didn't that trigger a

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-20 Thread Linus Walleij
On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga wrote: > Hi David, > > On 02/19/2015 08:59 PM, David Cohen wrote: >> Some Intel platforms have an USB OTG port fully (or partially) >> controlled by GPIOs: >> >> (1) USB ID is connected directly to a pulled up GPIO. >> >> Optionally: >> (2) VBUS is e

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-19 Thread Robert Baldyga
Hi David, On 02/19/2015 08:59 PM, David Cohen wrote: > Some Intel platforms have an USB OTG port fully (or partially) > controlled by GPIOs: > > (1) USB ID is connected directly to a pulled up GPIO. > > Optionally: > (2) VBUS is enabled/disabled by a GPIO > (3) Platform has 2 USB controllers con

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-19 Thread Paul Bolle
On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote: > As always, comments are welcome. Are nits welcome too? > +MODULE_LICENSE("GPLv2"); You probably meant MODULE_LICENSE("GPL v2") Didn't that trigger a warning or error? Paul Bolle -- To unsubscribe from this list: send the line "unsub

[PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-02-19 Thread David Cohen
Some Intel platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to a pulled up GPIO. Optionally: (2) VBUS is enabled/disabled by a GPIO (3) Platform has 2 USB controllers connected to same port: one for device and one for host role. D+/- ar