Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-12 Thread Greg Kroah-Hartman
On Tue, Mar 12, 2013 at 10:56:20AM +0100, Oliver Neukum wrote: > On Monday 11 March 2013 22:11:55 Bjørn Mork wrote: > > > What ever was decided here? Can someone please send me the patch that > > > you two agreed would solve this problem? > > > > I believe Oliver's patch titled "cdc-wdm: fix buff

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-12 Thread Oliver Neukum
On Monday 11 March 2013 22:11:55 Bjørn Mork wrote: > > What ever was decided here? Can someone please send me the patch that > > you two agreed would solve this problem? > > I believe Oliver's patch titled "cdc-wdm: fix buffer overflow" dated > Wed, 27 Feb 2013 10:29:02 +0100 was the conclusion t

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-11 Thread Bjørn Mork
Greg Kroah-Hartman writes: > On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: >> Oliver Neukum writes: >> > On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: >> >> Oliver Neukum writes: >> > >> >> > We have to let user space recover. To do so we need to indicate when >> >> > exact

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-11 Thread Greg Kroah-Hartman
On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: > Oliver Neukum writes: > > On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: > >> Oliver Neukum writes: > > > >> > We have to let user space recover. To do so we need to indicate when > >> > exactly we dropped data. > >> > >> The p

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-15 Thread Bjørn Mork
Oliver Neukum writes: > On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: >> Oliver Neukum writes: > >> > We have to let user space recover. To do so we need to indicate when >> > exactly we dropped data. >> >> The problem with that is that this is likely to happen when a client >> just does

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-15 Thread Oliver Neukum
On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: > Oliver Neukum writes: > > We have to let user space recover. To do so we need to indicate when > > exactly we dropped data. > > The problem with that is that this is likely to happen when a client > just doesn't care. It will just continue

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-14 Thread Bjørn Mork
Oliver Neukum writes: > On Thursday 14 February 2013 18:10:43 Bjørn Mork wrote: >> Do not scribble past end of buffer. Check if the userspace buffer has >> enough space available before attempting to move more data there. Drop >> new data on overflow. >> >> Cc: stable >> Signed-off-by: Bjørn Mo

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-14 Thread Oliver Neukum
On Thursday 14 February 2013 18:10:43 Bjørn Mork wrote: > Do not scribble past end of buffer. Check if the userspace buffer has > enough space available before attempting to move more data there. Drop > new data on overflow. > > Cc: stable > Signed-off-by: Bjørn Mork > --- > Oliver Neukum writ

[PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-14 Thread Bjørn Mork
Do not scribble past end of buffer. Check if the userspace buffer has enough space available before attempting to move more data there. Drop new data on overflow. Cc: stable Signed-off-by: Bjørn Mork --- Oliver Neukum writes: > I am afraid your diagnosis is correct. This is a buffer overflow.