Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-08 Thread Felipe Balbi
On Sat, Nov 08, 2014 at 06:45:59PM +0100, Robert Jarzmik wrote: > Felipe Balbi writes: > > > fine by me, as long as their all optional and agreed with devicetree dumb me: s/their/they're > > folks. I think we still have time for v3.19 if you manage to finish this > > before next week's end. > I

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-08 Thread Robert Jarzmik
Felipe Balbi writes: > fine by me, as long as their all optional and agreed with devicetree > folks. I think we still have time for v3.19 if you manage to finish this > before next week's end. I will try, no promise I'll succeed in this window. At least I should fire out within the next days the

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-05 Thread Felipe Balbi
Hi, On Wed, Nov 05, 2014 at 09:02:04PM +0100, Robert Jarzmik wrote: > Felipe Balbi writes: > > > On Wed, Nov 05, 2014 at 08:46:58PM +0100, Robert Jarzmik wrote: > > Well, let's add that :-) Just make it optional. It's pointless to have > > 80% duplicated code just because of 20% missing in phy-g

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-05 Thread Robert Jarzmik
Felipe Balbi writes: > On Wed, Nov 05, 2014 at 08:46:58PM +0100, Robert Jarzmik wrote: > Well, let's add that :-) Just make it optional. It's pointless to have > 80% duplicated code just because of 20% missing in phy-generic :-) > > Then we avoid adding gpio-vbus specific DT properties too. OK, g

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-05 Thread Felipe Balbi
On Wed, Nov 05, 2014 at 08:46:58PM +0100, Robert Jarzmik wrote: > Felipe Balbi writes: > > > Hi, > > > > On Sun, Nov 02, 2014 at 07:11:49PM +0100, Robert Jarzmik wrote: > >> In order to prepare device-tree conversion, port gpio_vbus to use > >> gpio_desc. > >> > >> Signed-off-by: Robert Jarzmik

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-05 Thread Robert Jarzmik
Felipe Balbi writes: > Hi, > > On Sun, Nov 02, 2014 at 07:11:49PM +0100, Robert Jarzmik wrote: >> In order to prepare device-tree conversion, port gpio_vbus to use >> gpio_desc. >> >> Signed-off-by: Robert Jarzmik > > Can we just convert users of this to a phy-generic.c with a regulator ? Maybe

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-05 Thread Felipe Balbi
Hi, On Sun, Nov 02, 2014 at 07:11:49PM +0100, Robert Jarzmik wrote: > In order to prepare device-tree conversion, port gpio_vbus to use > gpio_desc. > > Signed-off-by: Robert Jarzmik Can we just convert users of this to a phy-generic.c with a regulator ? This is basically what gpio-vbus is doi

Re: [PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-04 Thread Philipp Zabel
On Sun, Nov 2, 2014 at 7:11 PM, Robert Jarzmik wrote: > In order to prepare device-tree conversion, port gpio_vbus to use > gpio_desc. > > Signed-off-by: Robert Jarzmik Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body o

[PATCH v1 2/3] usb: phy: convert gpio-vbus to gpio_desc

2014-11-02 Thread Robert Jarzmik
In order to prepare device-tree conversion, port gpio_vbus to use gpio_desc. Signed-off-by: Robert Jarzmik --- drivers/usb/phy/phy-gpio-vbus-usb.c | 105 +++- 1 file changed, 56 insertions(+), 49 deletions(-) diff --git a/drivers/usb/phy/phy-gpio-vbus-usb.c b/dr