Re: [PATCH v1 14/14] usb: dwc2: host: use kmem cache to allocate descriptors

2015-10-16 Thread Doug Anderson
Gregory, On Fri, Oct 16, 2015 at 1:44 PM, Herrero, Gregory wrote: > I can't reproduce this issue so far but using GFP_DMA32 is obviously > wrong here, so I will replace with GFP_DMA. With that, I can definitely boot up. :) >> When I reverted this patch and tried to enable DMA descriptor >> tr

Re: [PATCH v1 14/14] usb: dwc2: host: use kmem cache to allocate descriptors

2015-10-16 Thread Herrero, Gregory
Hi Doug, On Thu, Oct 15, 2015 at 04:50:55PM -0700, Doug Anderson wrote: > Gregory, > > On Mon, Oct 12, 2015 at 2:17 AM, Gregory Herrero > wrote: > > - qh->desc_list = kzalloc(qh->desc_list_sz, flags | GFP_DMA32); > > + qh->desc_list = kmem_cache_zalloc(desc_cache, flags | GFP_DMA32);

Re: [PATCH v1 14/14] usb: dwc2: host: use kmem cache to allocate descriptors

2015-10-15 Thread Doug Anderson
Gregory, On Mon, Oct 12, 2015 at 2:17 AM, Gregory Herrero wrote: > - qh->desc_list = kzalloc(qh->desc_list_sz, flags | GFP_DMA32); > + qh->desc_list = kmem_cache_zalloc(desc_cache, flags | GFP_DMA32); I haven't gotten your series to work yet on Rockchip rk3288, but when I was trying

[PATCH v1 14/14] usb: dwc2: host: use kmem cache to allocate descriptors

2015-10-12 Thread Gregory Herrero
Kmem caches help to get correct boundary for descriptor buffers which need to be 512 bytes aligned for dwc2 controller. Two kmem caches are needed for generic descriptors and for hs isochronous descriptors which doesn't have same size. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/core.h