Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Felipe Balbi
Andy Shevchenko writes: > On Wed, Dec 05, 2018 at 11:18:45AM +0200, Andy Shevchenko wrote: >> On Wed, Dec 05, 2018 at 11:10:46AM +0200, Felipe Balbi wrote: >> > Andy Shevchenko writes: >> > >> > > The missed break statement in the outer switch makes the code fall >> > > through >> > > always a

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 05, 2018 at 11:18:45AM +0200, Andy Shevchenko wrote: > On Wed, Dec 05, 2018 at 11:10:46AM +0200, Felipe Balbi wrote: > > Andy Shevchenko writes: > > > > > The missed break statement in the outer switch makes the code fall through > > > always and thus always same value will be printed

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Andy Shevchenko
On Wed, Dec 05, 2018 at 11:10:46AM +0200, Felipe Balbi wrote: > Andy Shevchenko writes: > > > The missed break statement in the outer switch makes the code fall through > > always and thus always same value will be printed. > > > > Besides that, compiler warns about missed fall through marker: >

Re: [PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-05 Thread Felipe Balbi
Andy Shevchenko writes: > The missed break statement in the outer switch makes the code fall through > always and thus always same value will be printed. > > Besides that, compiler warns about missed fall through marker: > > drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’:

[PATCH v1] usb: dwc3: trace: Refactor nested switch to make compiler happy

2018-12-03 Thread Andy Shevchenko
The missed break statement in the outer switch makes the code fall through always and thus always same value will be printed. Besides that, compiler warns about missed fall through marker: drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’: drivers/usb/dwc3/./trace.h:246:4: w