Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
;> Subject: Re: [PATCH net 2/3] r8152: modify the tx flow >> >> From: Hayes Wang >> Date: Tue, 29 Oct 2013 15:56:16 +0800 >> >> > Support stopping and waking tx queue. The maximum tx queue length >> > is 60. >> >> What is so special about the

RE: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread hayeswang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, October 30, 2013 5:50 AM > To: Hayeswang > Cc: net...@vger.kernel.org; nic_swsd; > linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH net 2/3] r8152: modify the tx flow > > From: Hayes

Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
From: Hayes Wang Date: Tue, 29 Oct 2013 15:56:16 +0800 > Support stopping and waking tx queue. The maximum tx queue length > is 60. What is so special about the number 60? It seems arbitrary, and if it isn't arbitrary you haven't described why this value was choosen. I've asked you politely la

[PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread Hayes Wang
Let rtl8152_start_xmit() to queue packet only, and tx_bottom() would send all of the packets. This simplify the code and make sure all the packet would be sent by the original order. Support stopping and waking tx queue. The maximum tx queue length is 60. Signed-off-by: Hayes Wang --- drivers/n