Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Petko Manolov
On 17-02-07 10:32:16, Steve Calfee wrote: > On Mon, Feb 6, 2017 at 4:51 AM, Petko Manolov wrote: > > On 17-02-06 09:28:22, Greg KH wrote: > >> On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > >> > On 17-02-05 01:30:39, Greg KH wrote: > >> > > On Sat, Feb 04, 2017 at 04:56:03PM +000

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Steve Calfee
On Mon, Feb 6, 2017 at 4:51 AM, Petko Manolov wrote: > On 17-02-06 09:28:22, Greg KH wrote: >> On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: >> > On 17-02-05 01:30:39, Greg KH wrote: >> > > On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: >> > > > Allocating USB buff

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Petko Manolov
On 17-02-07 11:45:06, Greg KH wrote: > On Tue, Feb 07, 2017 at 12:24:12PM +0200, Petko Manolov wrote: > > On 17-02-06 14:46:21, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > > > On

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Greg KH
On Tue, Feb 07, 2017 at 12:24:12PM +0200, Petko Manolov wrote: > On 17-02-06 14:46:21, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Ma

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Petko Manolov
On 17-02-06 14:46:21, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > > > On 17-02-06 09:28:22, Greg KH wrote: > > > > > On

RE: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread David Laight
From: Petko Manolov > Sent: 06 February 2017 12:51 ... > I suspect getting the buffer allocation in usb_control_msg() will help with > two > things in the same time: > > - allocate in DMA-able memory; > - code reduction; Is there code around there to do 'bounce buffer' allocation for systems w

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread Johan Hovold
On Mon, Feb 06, 2017 at 02:32:23PM +0100, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > > On 17-02-06 09:28:22, Greg KH wrote: > > > > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread Johan Hovold
On Mon, Feb 06, 2017 at 02:21:24PM +0100, Johan Hovold wrote: > On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > > On 17-02-06 09:28:22, Greg KH wrote: > > > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > > > > > Random thought: isn't it better to add the alloc/fr

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread Johan Hovold
On Mon, Feb 06, 2017 at 02:51:09PM +0200, Petko Manolov wrote: > On 17-02-06 09:28:22, Greg KH wrote: > > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > > > Random thought: isn't it better to add the alloc/free code in > > > usb_control_msg() and avoid code duplication all over

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread Petko Manolov
On 17-02-06 09:28:22, Greg KH wrote: > On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > > On 17-02-05 01:30:39, Greg KH wrote: > > > On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: > > > > Allocating USB buffers on the stack is not portable, and no longer > > > > wor

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread Petko Manolov
On 17-02-05 01:30:39, Greg KH wrote: > On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: > > Allocating USB buffers on the stack is not portable, and no longer > > works on x86_64 (with VMAP_STACK enabled as per default). > > It's never worked on other platforms, so these should go to

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-06 Thread Greg KH
On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > On 17-02-05 01:30:39, Greg KH wrote: > > On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: > > > Allocating USB buffers on the stack is not portable, and no longer > > > works on x86_64 (with VMAP_STACK enabled as per def

Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-04 Thread Greg KH
On Sat, Feb 04, 2017 at 04:56:03PM +, Ben Hutchings wrote: > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). It's never worked on other platforms, so these should go to the stable releases please. thanks, greg k-h

[PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-04 Thread Ben Hutchings
Allocating USB buffers on the stack is not portable, and no longer works on x86_64 (with VMAP_STACK enabled as per default). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") References: https://bugs.debian.org/852556 Reported-by: Lisandro Damián Nicanor Pérez Meyer Tested-by: Lisandro Damián Nicanor Pére