Re: [PATCH net-next] r8152: use mutex for hw settings

2014-10-09 Thread David Miller
From: Hayes Wang Date: Thu, 9 Oct 2014 07:59:35 + > If I use the rtnl_lock(), I get a dead lock when enabling autosuspend. > > Case 1: >autosuspend before calling open. >rtnl_lock() >call open >try to autoresume and rtl8152_resume is called. >dead lock occurs. > > Case 2

RE: [PATCH net-next] r8152: use mutex for hw settings

2014-10-09 Thread Hayes Wang
David Miller [mailto:da...@davemloft.net] > Sent: Thursday, October 09, 2014 3:45 AM [..] > I think a much simpler fix is to take rtnl_lock() in the workqueue > function and suspend/resume ops. > > Every other place you are adding the mutex already holds the RTNL > mutex. If I use the rtnl_lock

Re: [PATCH net-next] r8152: use mutex for hw settings

2014-10-08 Thread David Miller
From: Hayes Wang Date: Tue, 7 Oct 2014 13:36:30 +0800 > Use mutex to avoid that the serial hw settings would be interrupted > by other settings. Although there is no problem now, it makes the > driver more safe. > > Signed-off-by: Hayes Wang I think a much simpler fix is to take rtnl_lock() in

[PATCH net-next] r8152: use mutex for hw settings

2014-10-06 Thread Hayes Wang
Use mutex to avoid that the serial hw settings would be interrupted by other settings. Although there is no problem now, it makes the driver more safe. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 69 +++-- 1 file changed, 67 insertions(+),