RE: [PATCH net] r8152: drop the tx packet with invalid length

2014-12-22 Thread Hayes Wang
> -Original Message- > From: Hayes Wang > Sent: Monday, December 22, 2014 10:23 AM > To: 'Eric Dumazet' > Cc: Tom Herbert; David Miller; net...@vger.kernel.org; > nic_swsd; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org > Subject: RE: [PATCH net]

RE: [PATCH net] r8152: drop the tx packet with invalid length

2014-12-21 Thread Hayes Wang
Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Saturday, December 20, 2014 2:14 AM [...] > Could you try following patch ? Thank you. I would test it. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ke

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-12-19 Thread Eric Dumazet
On Fri, 2014-12-19 at 09:36 -0800, Eric Dumazet wrote: > On Fri, 2014-12-19 at 06:42 +, Hayes Wang wrote: > > > Excuse me. I try to implement ndo_gso_check() with kernel 3.18. > > However, I still get packets with gso and their skb lengths are more > > than the acceptable one. Do I miss someth

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-12-19 Thread Eric Dumazet
On Fri, 2014-12-19 at 06:42 +, Hayes Wang wrote: > Excuse me. I try to implement ndo_gso_check() with kernel 3.18. > However, I still get packets with gso and their skb lengths are more > than the acceptable one. Do I miss something? > > +static bool rtl8152_gso_check(struct sk_buff *skb, str

RE: [PATCH net] r8152: drop the tx packet with invalid length

2014-12-18 Thread Hayes Wang
> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, November 27, 2014 4:34 AM [...] > >> > Looks like a candidate for ndo_gso_check(), so that we do not drop, but > >> > instead segment from netif_needs_gso()/validate_xmit_skb() > >> > >> You mean have the bridge implement the ndo

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Nov 2014 10:44:19 -0800 > On Wed, 2014-11-26 at 12:06 -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Wed, 26 Nov 2014 08:52:28 -0800 >> >> > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: >> >> Drop the tx packet which is more than the size of a

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread Eric Dumazet
On Wed, 2014-11-26 at 12:06 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 26 Nov 2014 08:52:28 -0800 > > > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: > >> Drop the tx packet which is more than the size of agg_buf_sz. When > >> creating a bridge with the device, we may get

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Nov 2014 08:52:28 -0800 > On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: >> Drop the tx packet which is more than the size of agg_buf_sz. When >> creating a bridge with the device, we may get the tx packet with >> TSO and the length is more than the gso_max_

Re: [PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread Eric Dumazet
On Wed, 2014-11-26 at 17:56 +0800, Hayes Wang wrote: > Drop the tx packet which is more than the size of agg_buf_sz. When > creating a bridge with the device, we may get the tx packet with > TSO and the length is more than the gso_max_size which is set by > the driver through netif_set_gso_max_size

[PATCH net] r8152: drop the tx packet with invalid length

2014-11-26 Thread Hayes Wang
Drop the tx packet which is more than the size of agg_buf_sz. When creating a bridge with the device, we may get the tx packet with TSO and the length is more than the gso_max_size which is set by the driver through netif_set_gso_max_size(). Such packets couldn't be transmitted and should be droppe