Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-04 Thread Ming Lei
On Tue, Sep 4, 2012 at 6:36 PM, Bjørn Mork wrote: > > I believe any Ericsson or Gobi modem would do, and most likely other USB > networking devices too. > > I haven't explored the gadget. Doesn't it support remote wakeup? Well, No. > it doesn't really have to just for testing this. You just h

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-04 Thread Bjørn Mork
Ming Lei writes: > On Tue, Sep 4, 2012 at 3:49 PM, Bjørn Mork wrote: >> >> That's easy: >> >> - Take any usbnet device supporting remote wakeup (and of course with a >> minidriver supporting it as well), >> - enable autosuspend, >> - ip link set dev ethX/usbX/wwanX up >> >> And watch ksoftirqd/

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-04 Thread Ming Lei
On Tue, Sep 4, 2012 at 3:49 PM, Bjørn Mork wrote: > > That's easy: > > - Take any usbnet device supporting remote wakeup (and of course with a > minidriver supporting it as well), > - enable autosuspend, > - ip link set dev ethX/usbX/wwanX up > > And watch ksoftirqd/X use 100% of one of your CPU

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-04 Thread Bjørn Mork
Bjørn Mork writes: > And I do believe the code before your change demonstrated that the > original authors had the same view. There was an explicit exception for > just this case, and I do assume that was put there for a good > reason. usbnet_bh() will be called while the device is suspended, an

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-04 Thread Bjørn Mork
Ming Lei writes: > On Mon, Sep 3, 2012 at 4:26 PM, Bjørn Mork wrote: > >> Sorry for not noticing this before, but commit 65841fd5 >> makes usbnet autosuspend completely unusable. The device >> is suspended fine, but burning one CPU core at full load >> uses a tiny bit more power making the power

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-03 Thread Ming Lei
On Mon, Sep 3, 2012 at 4:26 PM, Bjørn Mork wrote: > Suspending an open usbnet device results in constant > rescheduling of usbnet_bh. > > commit 65841fd5 "usbnet: handle remote wakeup asap" > refactored the usbnet_bh code to allow sharing the > urb allocate and submit code with usbnet_resume. In >

Re: [PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-03 Thread David Miller
From: Bjørn Mork Date: Mon, 3 Sep 2012 10:26:18 +0200 > Suspending an open usbnet device results in constant > rescheduling of usbnet_bh. > > commit 65841fd5 "usbnet: handle remote wakeup asap" > refactored the usbnet_bh code to allow sharing the > urb allocate and submit code with usbnet_resum

[PATCH net] net: usbnet: fix softirq storm on suspend

2012-09-03 Thread Bjørn Mork
Suspending an open usbnet device results in constant rescheduling of usbnet_bh. commit 65841fd5 "usbnet: handle remote wakeup asap" refactored the usbnet_bh code to allow sharing the urb allocate and submit code with usbnet_resume. In this process, a test for, and immediate return on, ENOLINK from