Re: [PATCH net] cdc_ether: Fix handling connection notification

2016-11-30 Thread Kristian Evensen
On Wed, Nov 30, 2016 at 10:51 PM, Bjørn Mork wrote: > Kristian Evensen writes: > >> +void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb) >> +{ >> + struct usb_cdc_notification *event; >> + >> + if (urb->actual_length < sizeof(*event)) >> + return; >> + >> + eve

Re: [PATCH net] cdc_ether: Fix handling connection notification

2016-11-30 Thread Bjørn Mork
Kristian Evensen writes: > +void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb) > +{ > + struct usb_cdc_notification *event; > + > + if (urb->actual_length < sizeof(*event)) > + return; > + > + event = urb->transfer_buffer; > + > + if (event->bNotificationT

Re: [PATCH net] cdc_ether: Fix handling connection notification

2016-11-30 Thread Henning Schild
Am Wed, 30 Nov 2016 19:42:16 +0100 schrieb Kristian Evensen : > Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") > introduced a work-around in usbnet_cdc_status() for devices that > exported cdc carrier on twice on connect. Before the commit, this > behavior caused the link st

[PATCH net] cdc_ether: Fix handling connection notification

2016-11-30 Thread Kristian Evensen
Commit bfe9b9d2df66 ("cdc_ether: Improve ZTE MF823/831/910 handling") introduced a work-around in usbnet_cdc_status() for devices that exported cdc carrier on twice on connect. Before the commit, this behavior caused the link state to be incorrect. It was assumed that all CDC Ethernet devices would