Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Sergei Shtylyov
On 07/25/2013 11:51 PM, Alan Cooper wrote: The node should be named just "usb", not "xhci" (no programming interface specific names), according to the ePAPR spec [1]. What about the existing node names "ohci@" and "ehci@"? Unfortunately, they are all wrong, as many others. It se

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Alan Cooper
On Thu, Jul 25, 2013 at 1:10 PM, Sergei Shtylyov wrote: > The node should be named just "usb", not "xhci" (no programming > interface > specific names), according to the ePAPR spec [1]. > > > What about the existing node names "ohci@" and "ehci@"? > > >>> Unfortunately,

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Sergei Shtylyov
On 25.07.2013 18:39, Alan Cooper wrote: It looks like all the feedback has been addressed, but I'm no device tree expert. Felipe, Matthijs, and Sergei, does this look good? If so, I'll queue to my xhci tree. Not quite there yet. Too bad I couldn't notice all the small issues at once..

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Alan Cooper
On Wed, Jul 24, 2013 at 6:10 PM, Sergei Shtylyov wrote: > Hello. > > > On 07/25/2013 01:21 AM, Sarah Sharp wrote: > >> It looks like all the feedback has been addressed, but I'm no device >> tree expert. > > >> Felipe, Matthijs, and Sergei, does this look good? If so, I'll queue to >> my xhci tre

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 02:10:46AM +0400, Sergei Shtylyov wrote: > >>+ compatible = "xhci-platform"; > >It again looks somewhat like a driver name, not a device name. > What made you change the value from "usb-xhci", Al? Look at > [eo]hci-omap.txt in that directory. I asked. us

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-24 Thread Sergei Shtylyov
Hello. On 07/25/2013 01:21 AM, Sarah Sharp wrote: It looks like all the feedback has been addressed, but I'm no device tree expert. Felipe, Matthijs, and Sergei, does this look good? If so, I'll queue to my xhci tree. Not quite there yet. Too bad I couldn't notice all the small issues

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-24 Thread Sarah Sharp
It looks like all the feedback has been addressed, but I'm no device tree expert. Felipe, Matthijs, and Sergei, does this look good? If so, I'll queue to my xhci tree. Sarah Sharp On Tue, Jul 23, 2013 at 06:35:33PM -0400, Al Cooper wrote: > Add Device Tree match table to xhci-plat.c. Add DT bin

[PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-23 Thread Al Cooper
Add Device Tree match table to xhci-plat.c. Add DT bindings document. Signed-off-by: Al Cooper --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 14 ++ drivers/usb/host/xhci-plat.c | 10 ++ 2 files changed, 24 insertions(+) create mode 100644 Doc