Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 13, 2017 at 11:57:14AM +0200, Johan Hovold wrote: > On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > > > On Tue, 6 Jun 2017 12:54:40 +0200 > > > Johan Hovold wrote: > > > > > > > Remove three ifdefed a

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-13 Thread Johan Hovold
On Tue, Jun 13, 2017 at 11:57:14AM +0200, Johan Hovold wrote: > On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > > > On Tue, 6 Jun 2017 12:54:40 +0200 > > > Johan Hovold wrote: > > > > > > > Remove three ifdefed a

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-13 Thread Johan Hovold
On Tue, Jun 13, 2017 at 11:48:41AM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > > On Tue, 6 Jun 2017 12:54:40 +0200 > > Johan Hovold wrote: > > > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and > > > TIOCGICOUNT, and parity

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-13 Thread Greg Kroah-Hartman
On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > On Tue, 6 Jun 2017 12:54:40 +0200 > Johan Hovold wrote: > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and > > TIOCGICOUNT, and parity handling in set_termios which had suffered > > severe bit rot. > > I would be

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-06 Thread Alan Cox
On Tue, 6 Jun 2017 12:54:40 +0200 Johan Hovold wrote: > Remove three ifdefed and broken implementations of TIOCSSERIAL and > TIOCGICOUNT, and parity handling in set_termios which had suffered > severe bit rot. I would be amazed if the IRDA code still works. It's not been tested properly for yea

[PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-06 Thread Johan Hovold
Remove three ifdefed and broken implementations of TIOCSSERIAL and TIOCGICOUNT, and parity handling in set_termios which had suffered severe bit rot. Signed-off-by: Johan Hovold --- net/irda/ircomm/ircomm_tty_ioctl.c | 107 + 1 file changed, 1 insertion(+), 10