Good idea.
I am going to define ep_* and use them.
btw, DEBUG cannot be used if not unset, because there is a namespace collision.
Regards!
On Mon, May 19, 2014 at 10:29 PM, Joe Perches wrote:
> On Mon, 2014-05-19 at 16:17 -0400, Alan Stern wrote:
>> On Mon, 19 May 2014, Ricardo Ribalda Del
On Mon, 2014-05-19 at 16:17 -0400, Alan Stern wrote:
> On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
> > I really think that setting/unsetting DEBUG and VERBOSE is not a good
> > idea, and the generic functions are there to be used.
> You could change the definitions of DEBUG and VDEBUG to ma
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
> Hello Alan
>
> I really think that setting/unsetting DEBUG and VERBOSE is not a good
> idea, and the generic functions are there to be used.
You could change the definitions of DEBUG and VDEBUG to make them use
the generic functions.
> What
Hello Alan
I really think that setting/unsetting DEBUG and VERBOSE is not a good
idea, and the generic functions are there to be used.
What do you think that makes it more difficult to read? The GETDEV macro?
Cheers
On Mon, May 19, 2014 at 9:44 PM, Alan Stern wrote:
> On Mon, 19 May 2014, Rica
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:
> Driver was using custom functions WARNING, ERROR, DEBUG, instead of
> pr_err, pr_dgb...
What's wrong with that, and why bother to change it?
> diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
> index e67ae96..11800bb
Hello Joe
OK, then I will use dev_vdbg. Thanks!
On Mon, May 19, 2014 at 9:42 PM, Joe Perches wrote:
> On Mon, 2014-05-19 at 21:33 +0200, Ricardo Ribalda Delgado wrote:
>> I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
>> replaced it with dev_dbg.
>>
>> But if you prefer
On Mon, 2014-05-19 at 21:33 +0200, Ricardo Ribalda Delgado wrote:
> I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
> replaced it with dev_dbg.
>
> But if you prefer to use dev_dbg, I will modify it to use dev_dbg
s/VDEBUG/dev_vdbg/
dev_vdbg can be controlled by DYNAMIC_DEBU
Hello Joe
I think dev_vdg cannot be controlled with DYNAMIC_DEBUG, therefore I
replaced it with dev_dbg.
But if you prefer to use dev_dbg, I will modify it to use dev_dbg
Thanks!
On Mon, May 19, 2014 at 9:16 PM, Joe Perches wrote:
> On Mon, 2014-05-19 at 21:11 +0200, Ricardo Ribalda Delgado w
On Mon, 2014-05-19 at 21:11 +0200, Ricardo Ribalda Delgado wrote:
> VDEBUG has also been replaced by DEBUG because the same functionality
> (or even better) can be achieved with dynamic printk.
dev_vdbg exists for that purpose.
--
To unsubscribe from this list: send the line "unsubscribe l
Driver was using custom functions WARNING, ERROR, DEBUG, instead of
pr_err, pr_dgb...
VDEBUG has also been replaced by DEBUG because the same functionality
(or even better) can be achieved with dynamic printk.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/usb/gadget/net2280.c | 130 ++
10 matches
Mail list logo
