Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-27 Thread Tony Lindgren
* Sergei Shtylyov [150227 06:27]: > Hello. > > On 2/27/2015 5:17 PM, Robert Abel wrote: > > >>Documentation/kernel-doc-nano-HOWTO.txt requires colons after the > >>parameter names, doesn't it? > > >Jesus Christ, you guys are killing me... > >I've already spent way more time on this patch se

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-27 Thread Sergei Shtylyov
Hello. On 2/27/2015 5:17 PM, Robert Abel wrote: Documentation/kernel-doc-nano-HOWTO.txt requires colons after the parameter names, doesn't it? Jesus Christ, you guys are killing me... I've already spent way more time on this patch series than I intended to anyway... That's what you

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-27 Thread Robert Abel
On Thu, Feb 26, 2015 at 4:06 PM, Sergei Shtylyov wrote: >Documentation/kernel-doc-nano-HOWTO.txt requires colons after the > parameter names, doesn't it? Jesus Christ, you guys are killing me... I've already spent way more time on this patch series than I intended to anyway... >> + mas

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-27 Thread Robert Abel
Hi Roger, On Fri, Feb 27, 2015 at 11:43 AM, Roger Quadros wrote: >> time_ns_min = gpmc_ticks_to_ns(l ? l - 1 : 0); > > should be > time_ns_min = l ? gpmc_ticks_to_ns(l - 1) + 1 : 0; That's a micro-optimization. > > + 1ns since we don't want to fall in

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-27 Thread Roger Quadros
Robert, On 26/02/15 16:45, Robert ABEL wrote: > DTS output was formatted to require additional work when copy-pasting into > DTS. > Nano-second timings were replaced with interval of values that produce the > same > number of clock ticks. > > Signed-off-by: Robert ABEL > --- > drivers/memory/

Re: [PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-26 Thread Sergei Shtylyov
Hello. On 02/26/2015 05:45 PM, Robert ABEL wrote: DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were replaced with interval of values that produce the same number of clock ticks. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.

[PATCH 4/8] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-26 Thread Robert ABEL
DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were replaced with interval of values that produce the same number of clock ticks. Signed-off-by: Robert ABEL --- drivers/memory/omap-gpmc.c | 35 ++- 1 file change