Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-04-02 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 03:18:14PM +0200, Alexander Shishkin wrote: > >> >> + dr_mode = ci->platdata->dr_mode; > >> >> + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == > >> >> USB_DR_MODE_DUAL_ROLE) > >> >> + dr_mode = USB_DR_MODE_OTG; > >> >> +

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Alexander Shishkin
Felipe Balbi writes: > Hi, Hi, > On Thu, Mar 28, 2013 at 01:13:00PM +0200, Alexander Shishkin wrote: >> >> + dr_mode = ci->platdata->dr_mode; >> >> + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == >> >> USB_DR_MODE_DUAL_ROLE) >> >> + dr_mode = USB_DR_M

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 01:13:00PM +0200, Alexander Shishkin wrote: > >> + dr_mode = ci->platdata->dr_mode; > >> + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == > >> USB_DR_MODE_DUAL_ROLE) > >> + dr_mode = USB_DR_MODE_OTG; > >> + > >>

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-28 Thread Alexander Shishkin
Felipe Balbi writes: > Hi, > > On Fri, Mar 08, 2013 at 10:55:46PM +0200, Alexander Shishkin wrote: >> + dr_mode = ci->platdata->dr_mode; >> + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == >> USB_DR_MODE_DUAL_ROLE) >> + dr_mode = USB_DR_MODE_OTG; >>

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-10 Thread Felipe Balbi
Hi, On Fri, Mar 08, 2013 at 10:55:46PM +0200, Alexander Shishkin wrote: > + dr_mode = ci->platdata->dr_mode; > + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == > USB_DR_MODE_DUAL_ROLE) > + dr_mode = USB_DR_MODE_OTG; > + > /* initialize rol

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Alexander Shishkin
On 8 March 2013 18:52, Marc Kleine-Budde wrote: > On 03/08/2013 05:46 PM, Alexander Shishkin wrote: >> On 8 March 2013 18:33, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Marc Kleine-Budde
On 03/08/2013 05:46 PM, Alexander Shishkin wrote: > On 8 March 2013 18:33, Felipe Balbi wrote: >> Hi, >> >> On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: >>> @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev) >>> return -ENODEV; >>>

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Alexander Shishkin
On 8 March 2013 18:33, Felipe Balbi wrote: > Hi, > > On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: >> @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev) >> return -ENODEV; >> } >> >> + /* For now we treat dual-role as otg */ >>

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-03-08 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 11:57:02AM +0100, Marc Kleine-Budde wrote: > @@ -487,14 +488,23 @@ static int ci_hdrc_probe(struct platform_device *pdev) > return -ENODEV; > } > > + /* For now we treat dual-role as otg */ > + dr_mode = ci->platdata->dr_mode; > + if (d

[PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-02-28 Thread Marc Kleine-Budde
From: Sascha Hauer Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- drivers/usb/chipidea/co

[PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-02-27 Thread Marc Kleine-Budde
From: Sascha Hauer Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- drivers/usb/chipidea/co