Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-27 Thread Felipe Balbi
On Thu, Feb 27, 2014 at 03:05:14PM -0300, Fabio Estevam wrote: > On Thu, Feb 27, 2014 at 12:30 AM, Peter Chen wrote: > > >> btw, when can I remove fsl_udc_core.c from the tree ? > >> > > > > Freescale has other processor group (PowerPC, etc) has used this code now. > > Not only PowerPC, but also

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-27 Thread Fabio Estevam
On Thu, Feb 27, 2014 at 12:30 AM, Peter Chen wrote: >> btw, when can I remove fsl_udc_core.c from the tree ? >> > > Freescale has other processor group (PowerPC, etc) has used this code now. Not only PowerPC, but also the imx platforms that have not been converted to device tree yet. -- To unsub

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-27 Thread Felipe Balbi
On Thu, Feb 27, 2014 at 03:30:03AM +, Peter Chen wrote: > > > > > > > > > > > > > Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data > > > > > > Stage, USB > > > > > 2.0 spec? > > > > > > > > > > wait, this is a chipidea core ? Why aren't you guys using the > > > > > chipidea dr

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-27 Thread Neil Zhang
ATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0 > > Hi, > > On Tue, Feb 25, 2014 at 05:48:17PM -0800, Neil Zhang wrote: > > > > > > > > > Hardware zlt will try to send the zero length packet > > > > > > > > > automatically when the d

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Peter Chen
> > > > > > > > > > Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data > > > > > Stage, USB > > > > 2.0 spec? > > > > > > > > wait, this is a chipidea core ? Why aren't you guys using the > > > > chipidea driver yet ? You need to switch over to that driver dude, > > > > we can't hav

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Felipe Balbi
On Wed, Feb 26, 2014 at 02:36:19AM +, Peter Chen wrote: > > > > > > easy to be found. > > > > > > > > > > > > > Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data > > > > Stage, USB > > > 2.0 spec? > > > > > > wait, this is a chipidea core ? Why aren't you guys using the chipide

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Felipe Balbi
On Wed, Feb 26, 2014 at 02:36:19AM +, Peter Chen wrote: > > > > > > easy to be found. > > > > > > > > > > > > > Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data > > > > Stage, USB > > > 2.0 spec? > > > > > > wait, this is a chipidea core ? Why aren't you guys using the chipide

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-26 Thread Felipe Balbi
Hi, On Tue, Feb 25, 2014 at 05:48:17PM -0800, Neil Zhang wrote: > > > > > > > > Hardware zlt will try to send the zero length packet > > > > > > > > automatically when the data transferd is multiple times of > > > > > > > > max packet, this will cause issues on Windows. > > > > > > > > So let's di

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-25 Thread Peter Chen
> > > > easy to be found. > > > > > > > > > > Chipidea bug too? Does it follow ch 8.5.3.2 Variable-length Data > > > Stage, USB > > 2.0 spec? > > > > wait, this is a chipidea core ? Why aren't you guys using the chipidea > > driver yet ? You need to switch over to that driver dude, we can't > > h

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-25 Thread Neil Zhang
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: 2014年2月26日 2:13 > To: Peter Chen > Cc: Neil Zhang; ba...@ti.com; gre...@linuxfoundation.org; > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Alexander Shishkin > Subject: Re: [PATCH 2/6

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-25 Thread Felipe Balbi
Hi, On Tue, Feb 25, 2014 at 07:46:08AM +, Peter Chen wrote: > > > > > > Hardware zlt will try to send the zero length packet > > > > > > automatically when the data transferd is multiple times of max > > > > > > packet, this will cause issues on Windows. > > > > > > So let's disable HW zlt by

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Peter Chen
> > > > > > > > > > > > On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote: > > > > > Hardware zlt will try to send the zero length packet > > > > > automatically when the data transferd is multiple times of max > > > > > packet, this will cause issues on Windows. > > > > > So let's dis

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 13:15 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: RE: [PATCH 2/6] usb: gadget: mv_ud

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Peter Chen
> > On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote: > > > Hardware zlt will try to send the zero length packet automatically > > > when the data transferd is multiple times of max packet, this will > > > cause issues on Windows. > > > So let's disable HW zlt by default. > > > > Woul

RE: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Neil Zhang
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: 2014年2月25日 9:19 > To: Neil Zhang > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH 2/6] usb: gadget: mv_ud

Re: [PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Peter Chen
On Mon, Feb 24, 2014 at 04:03:12PM +0800, Neil Zhang wrote: > Hardware zlt will try to send the zero length packet automatically > when the data transferd is multiple times of max packet, this will > cause issues on Windows. > So let's disable HW zlt by default. Would you have description that wha

[PATCH 2/6] usb: gadget: mv_udc: disable HW zlt for ep0

2014-02-24 Thread Neil Zhang
Hardware zlt will try to send the zero length packet automatically when the data transferd is multiple times of max packet, this will cause issues on Windows. So let's disable HW zlt by default. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |2 +- 1 file changed, 1 insertion