Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On Mon, Feb 29, 2016 at 3:20 AM, Petr Kulhavy wrote: > > > On 26.02.2016 15:23, Bin Liu wrote: >> >> Hi, >> >> On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: >>> >>> On 26.02.2016 04:15, Bin Liu wrote: On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote:

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hi, On Mon, Feb 29, 2016 at 12:23:46PM -0600, Bin Liu wrote: > Hi, > > On Mon, Feb 29, 2016 at 10:20:55AM +0100, Petr Kulhavy wrote: > > > > > > On 26.02.2016 15:23, Bin Liu wrote: > > >Hi, > > > > > >On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: > > >>On 26.02.2016 04:15, Bin L

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hi, On Mon, Feb 29, 2016 at 10:20:55AM +0100, Petr Kulhavy wrote: > > > On 26.02.2016 15:23, Bin Liu wrote: > >Hi, > > > >On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: > >>On 26.02.2016 04:15, Bin Liu wrote: > >>>On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: > >>>

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On 26.02.2016 15:23, Bin Liu wrote: Hi, On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: On 26.02.2016 04:15, Bin Liu wrote: On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: Well, so we're still at the same point - there is a fundamental mismatch in the different

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hi, On Fri, Feb 26, 2016 at 10:29:12AM +0100, Petr Kulhavy wrote: > > On 26.02.2016 04:15, Bin Liu wrote: > >On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: > > > >>Well, so we're still at the same point - there is a fundamental > >>mismatch in the different developers' view how the

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On 26.02.2016 04:15, Bin Liu wrote: On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: Well, so we're still at the same point - there is a fundamental mismatch in the different developers' view how the "power" parameter should be represented. There already 3 opinions at the moment:

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hi, On Wed, Feb 24, 2016 at 04:27:15PM +0100, Petr Kulhavy wrote: > This adds two functions to get DT properties "mentor,power" and "dr_mode": > musb_get_power() and musb_get_mode() Sorry for my late comments, but I don't see the value of adding musb_get_power() into musb core. It is just a wrape

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hi, On Thu, Feb 25, 2016 at 01:04:13PM +0100, Petr Kulhavy wrote: > On 25.02.2016 12:53, Sergei Shtylyov wrote: > > > >>> I then fail to understand the logic behind hard coding. > >> > >>And I fail to understand your plans with the other drivers. > >>Are you trying to say that the "mentor,power"

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On 25.02.2016 12:53, Sergei Shtylyov wrote: I then fail to understand the logic behind hard coding. And I fail to understand your plans with the other drivers. Are you trying to say that the "mentor,power" (or "power" in OMAP2430) property should be completely abandoned and the values hard

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hello. On 2/25/2016 11:55 AM, Petr Kulhavy wrote: +#if IS_ENABLED(CONFIG_OF) +/* gets the "mentor,power" property from DT + * and converts it from mA to 2mA units for the "power" parameter + * in struct musb_hdrc_platform_data + * + * in case the property is not found returns 0 + */ +extern u8

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On 24.02.2016 18:30, Sergei Shtylyov wrote: On 02/24/2016 08:10 PM, Petr Kulhavy wrote: +#if IS_ENABLED(CONFIG_OF) +/* gets the "mentor,power" property from DT + * and converts it from mA to 2mA units for the "power" parameter + * in struct musb_hdrc_platform_data + * + * in case the propert

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On 02/24/2016 08:10 PM, Petr Kulhavy wrote: +#if IS_ENABLED(CONFIG_OF) +/* gets the "mentor,power" property from DT + * and converts it from mA to 2mA units for the "power" parameter + * in struct musb_hdrc_platform_data + * + * in case the property is not found returns 0 + */ +extern u8 musb_g

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

On 24.02.2016 18:00, Sergei Shtylyov wrote: +#if IS_ENABLED(CONFIG_OF) +/* gets the "mentor,power" property from DT + * and converts it from mA to 2mA units for the "power" parameter + * in struct musb_hdrc_platform_data + * + * in case the property is not found returns 0 + */ +extern u8 musb_

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hello. On 02/24/2016 06:27 PM, Petr Kulhavy wrote: This adds two functions to get DT properties "mentor,power" and "dr_mode": musb_get_power() and musb_get_mode() Signed-off-by: Petr Kulhavy --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - add

Re: [PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

Hi, Petr Kulhavy writes: > This adds two functions to get DT properties "mentor,power" and "dr_mode": > musb_get_power() and musb_get_mode() > > Signed-off-by: Petr Kulhavy Bin, is this okay for you ? > --- > v4: > - created musb_get_dr_mode() > > v5: > - musb_get_dr_mode() renamed to musb

[PATCH 2/5 v7] usb: musb: core: added helper functions for parsing DT

This adds two functions to get DT properties "mentor,power" and "dr_mode": musb_get_power() and musb_get_mode() Signed-off-by: Petr Kulhavy --- v4: - created musb_get_dr_mode() v5: - musb_get_dr_mode() renamed to musb_get_mode() - added musb_get_power() v6: - musb_get_power() : added missi