Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
Hi again, On Wed, Sep 19, 2012 at 08:24:44PM +0300, Felipe Balbi wrote: > > > at minimum this should've come with a proper revision check anyway. > > > > > > > Actually most of it is under a rev check :) > > fair enough. one extra comment here. That revision check is not related to the silicon

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
On Wed, Sep 19, 2012 at 11:50:53AM -0500, Sonasath, Moiz wrote: > Felipe, > > On Wed, Sep 19, 2012 at 11:04 AM, Felipe Balbi wrote: > > > Hi, > > > > On Wed, Sep 19, 2012 at 10:02:48AM -0500, Sonasath, Moiz wrote: > > > Felipe, > > > > > > On Wed, Sep 19, 2012 at 6:53 AM, Felipe Balbi wrote: >

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
Hi, On Wed, Sep 19, 2012 at 10:02:48AM -0500, Sonasath, Moiz wrote: > Felipe, > > On Wed, Sep 19, 2012 at 6:53 AM, Felipe Balbi wrote: > > > Hi, > > > > On Wed, Sep 19, 2012 at 05:00:27PM +0530, Kishon Vijay Abraham I wrote: > > > From: Moiz Sonasath > > > > > > For the gadget pullup functiona

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
Hi, On Wed, Sep 19, 2012 at 05:00:27PM +0530, Kishon Vijay Abraham I wrote: > From: Moiz Sonasath > > For the gadget pullup functionality to work in > SS mode it requires a particular sequence of > toggling the run-stop bit. Here is the required > sequence: > > - Set DCTL[31] > - Clear DCTL[31]

[PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Kishon Vijay Abraham I
From: Moiz Sonasath For the gadget pullup functionality to work in SS mode it requires a particular sequence of toggling the run-stop bit. Here is the required sequence: - Set DCTL[31] - Clear DCTL[31] - Clear OMAP5430_CONTROL_CORE__PHY_POWER_USB[14] - Clear DCTL[8:5] = 0x00 - Set DCTL[8:5] = 0x