Re: [PATCH 2/4] cdc-acm: Convert acm_minors to XArray

2019-03-19 Thread Matthew Wilcox
On Tue, Mar 19, 2019 at 01:14:20PM +0100, Greg KH wrote: > On Mon, Mar 18, 2019 at 02:17:11PM -0700, Matthew Wilcox wrote: > > Signed-off-by: Matthew Wilcox > > Also something here saying acm_minors was an idr structure that is being > converted to xarray. ACK. > > @@ -86,20 +86,15 @@ static st

Re: [PATCH 2/4] cdc-acm: Convert acm_minors to XArray

2019-03-19 Thread Oliver Neukum
On Di, 2019-03-19 at 13:14 +0100, Greg KH wrote: > On Mon, Mar 18, 2019 at 02:17:11PM -0700, Matthew Wilcox wrote: > > Signed-off-by: Matthew Wilcox [..] > > static int acm_alloc_minor(struct acm *acm) > > { > > - int minor; > > - > > - mutex_lock(&acm_minors_lock); > > - minor = idr_allo

Re: [PATCH 2/4] cdc-acm: Convert acm_minors to XArray

2019-03-19 Thread Oliver Neukum
On Mo, 2019-03-18 at 14:17 -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox Straight replacement. Looks fine to me. But without a commit message Greg would dismember both of us. Regards Oliver

Re: [PATCH 2/4] cdc-acm: Convert acm_minors to XArray

2019-03-19 Thread Greg KH
On Mon, Mar 18, 2019 at 02:17:11PM -0700, Matthew Wilcox wrote: > Signed-off-by: Matthew Wilcox Also something here saying acm_minors was an idr structure that is being converted to xarray. > --- > drivers/usb/class/cdc-acm.c | 33 ++--- > 1 file changed, 14 insertio

[PATCH 2/4] cdc-acm: Convert acm_minors to XArray

2019-03-18 Thread Matthew Wilcox
Signed-off-by: Matthew Wilcox --- drivers/usb/class/cdc-acm.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 739f8960811a..28eb9a898b4a 100644 --- a/drivers/usb/class/cdc-acm.c