Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-28 Thread Andrew Lunn
On Tue, May 28, 2013 at 11:08:54PM +0200, Johan Hovold wrote: > On Tue, May 28, 2013 at 09:41:08PM +0200, Andrew Lunn wrote: > > On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: > > > On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: > > > > +/* > > > > + * mxuport_write_roo

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-28 Thread Johan Hovold
On Tue, May 28, 2013 at 09:41:08PM +0200, Andrew Lunn wrote: > On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: > > On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: > > > +/* > > > + * mxuport_write_room > > > + * > > > + * Return how much space is available in the buffer.

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-28 Thread Andrew Lunn
On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: > On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: > > +/* > > + * mxuport_write_room > > + * > > + * Return how much space is available in the buffer. > > + */ > > +static int mxuport_write_room(struct tty_struct *tty) > > +

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-27 Thread Johan Hovold
On Sun, May 26, 2013 at 07:19:03PM +0200, Andrew Lunn wrote: > On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: > > On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: [...] > > > +/* > > > + * mxuport_prepare_write_buffer - fill in the buffer, ready for > > > + * sending >

Re: [PATCH 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-05-26 Thread Andrew Lunn
On Sun, May 26, 2013 at 06:04:24PM +0200, Johan Hovold wrote: > On Sun, May 26, 2013 at 01:00:51PM +0200, Andrew Lunn wrote: > > Add a driver which supports the following Moxa USB to serial converters: > > * 2 ports : UPort 1250, UPort 1250I > > * 4 ports : UPort 1410, UPort 1450, UPort