Re: [PATCH 2/2] usb: ohci-pxa27x: add regulators for usb devices

2013-10-20 Thread Nikita Kiryanov
On 10/18/2013 05:23 PM, Alan Stern wrote: What happens to ext_regulator[0] if you fail to enable ext_regulator[1]? Does it remain permanently enabled? It will be turned off when pxa27x_stop_hc is called. Ah, I see. You enable regulators only in pxa27x_start_hc() and disable them only in pxa

Re: [PATCH 2/2] usb: ohci-pxa27x: add regulators for usb devices

2013-10-18 Thread Alan Stern
On Fri, 18 Oct 2013, Nikita Kiryanov wrote: > >> + for (i = 0; i < PXA_UHC_MAX_PORTNUM; i++) { > >> + retval = 0; > >> + if (ohci->ext_regulator[i]) > >> + retval = regulator_enable(ohci->ext_regulator[i]); > >> + > >> + if (retval) > >> +

Re: [PATCH 2/2] usb: ohci-pxa27x: add regulators for usb devices

2013-10-18 Thread Nikita Kiryanov
On 10/16/2013 05:58 PM, Alan Stern wrote: On Wed, 16 Oct 2013, Nikita Kiryanov wrote: Add regulator support for devices that sit on USB ports, thus allowing usb devices power management for suspend/resume. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Nikita Kiryanov Signed-off-by: I

Re: [PATCH 2/2] usb: ohci-pxa27x: add regulators for usb devices

2013-10-16 Thread Alan Stern
On Wed, 16 Oct 2013, Nikita Kiryanov wrote: > Add regulator support for devices that sit on USB ports, > thus allowing usb devices power management for suspend/resume. > > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Signed-off-by: Nikita Kiryanov > Signed-off-by: Igor Grinberg > --- > drivers/

[PATCH 2/2] usb: ohci-pxa27x: add regulators for usb devices

2013-10-16 Thread Nikita Kiryanov
Add regulator support for devices that sit on USB ports, thus allowing usb devices power management for suspend/resume. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Nikita Kiryanov Signed-off-by: Igor Grinberg --- drivers/usb/host/ohci-pxa27x.c | 47 +++