Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-09 Thread Bin Liu
On Mon, Feb 9, 2015 at 12:39 PM, Tony Lindgren wrote: > * Bin Liu [150206 10:21]: >> Tony, >> >> On Fri, Feb 6, 2015 at 11:23 AM, Tony Lindgren wrote: >> > * George Cherian [150206 05:05]: >> >> Hi Tony, >> >> >> >> You also need to add similar things in dsps_musb_reset(); >> >> >> >> Otherwise

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-09 Thread Tony Lindgren
* George Cherian [150208 22:02]: > Hi Tony, > On 02/06/2015 10:53 PM, Tony Lindgren wrote: > >* George Cherian [150206 05:05]: > >>Hi Tony, > >> > >>You also need to add similar things in dsps_musb_reset(); > >> > >>Otherwise you might not recover from a BABBLE condition. > >Thank I totally misse

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-09 Thread Tony Lindgren
* Bin Liu [150206 10:21]: > Tony, > > On Fri, Feb 6, 2015 at 11:23 AM, Tony Lindgren wrote: > > * George Cherian [150206 05:05]: > >> Hi Tony, > >> > >> You also need to add similar things in dsps_musb_reset(); > >> > >> Otherwise you might not recover from a BABBLE condition. > > > > Thank I t

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-08 Thread George Cherian
Hi Tony, On 02/06/2015 10:53 PM, Tony Lindgren wrote: * George Cherian [150206 05:05]: Hi Tony, You also need to add similar things in dsps_musb_reset(); Otherwise you might not recover from a BABBLE condition. Thank I totally missed that, updated patch below. Do you have some testcase that

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-06 Thread Tony Lindgren
* George Cherian [150206 05:05]: > Hi Tony, > > You also need to add similar things in dsps_musb_reset(); > > Otherwise you might not recover from a BABBLE condition. Thank I totally missed that, updated patch below. Do you have some testcase that easily triggers BABBLE on MUSB? Regards, Ton

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-06 Thread Bin Liu
Tony, On Fri, Feb 6, 2015 at 11:23 AM, Tony Lindgren wrote: > * George Cherian [150206 05:05]: >> Hi Tony, >> >> You also need to add similar things in dsps_musb_reset(); >> >> Otherwise you might not recover from a BABBLE condition. > > Thank I totally missed that, updated patch below. > > Do y

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-06 Thread George Cherian
Hi Tony, You also need to add similar things in dsps_musb_reset(); Otherwise you might not recover from a BABBLE condition. On 02/05/2015 10:05 PM, Tony Lindgren wrote: We still have a combination of legacy phys and generic phys in use so we need to support both types of phy for musb_dsps.c.

[PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-05 Thread Tony Lindgren
We still have a combination of legacy phys and generic phys in use so we need to support both types of phy for musb_dsps.c. Cc: Brian Hutchinson Signed-off-by: Tony Lindgren --- drivers/usb/musb/musb_dsps.c | 17 + 1 file changed, 17 insertions(+) --- a/drivers/usb/musb/musb_ds