Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-25 Thread Felipe Balbi
On Tue, Nov 25, 2014 at 08:35:00AM +0100, Robert Jarzmik wrote: > Felipe Balbi writes: > > > On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote: > >> Felipe Balbi writes: > >> > >> > @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { > >> > } while (0)

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Robert Jarzmik
Felipe Balbi writes: > On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote: >> Felipe Balbi writes: >> >> > @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { >> >} while (0) >> > #define remove_debug_files(dev) \ >> >do { \ >> > - if (dev->deb

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Felipe Balbi
On Mon, Nov 24, 2014 at 10:45:03PM +0100, Robert Jarzmik wrote: > Felipe Balbi writes: > > > @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { > > } while (0) > > #define remove_debug_files(dev) \ > > do { \ > > - if (dev->debugfs_udc) \ > > -

Re: [PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Robert Jarzmik
Felipe Balbi writes: > @@ -1136,8 +1136,7 @@ static const struct file_operations debug_fops = { > } while (0) > #define remove_debug_files(dev) \ > do { \ > - if (dev->debugfs_udc) \ > - debugfs_remove(dev->debugfs_udc); \ > + debugfs_remov

[PATCH 2/2] usb: gadget: udc: pxa25x: remove unnecessary NULL check

2014-11-24 Thread Felipe Balbi
debugfs_remove() is safe against NULL pointers, so let's remove the unnecessary NULL check before calling it. Cc: Daniel Mack Cc: Robert Jarzmik Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/pxa25x_udc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb