Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-21 Thread Sergei Shtylyov
Hello. On 21-01-2013 6:20, Wei Shuai wrote: The main problem is that these devices don't support ethernet. They support IP (v4 and _maybe_ v6) with an ethernet header. Many of them will do ARP (and IPv6 ND) as well to complete the picture, but some of them don't and that's what these drivers

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-21 Thread Wei Shuai
Thank you David. yes in the core driver, FLAG_NOARP will be translated to IFF_NOARP 2013/1/21, David Miller : > From: Wei Shuai > Date: Mon, 21 Jan 2013 10:20:22 +0800 > >> The main problem is that these devices don't support ethernet. > > He's saying your comment is referring to the wrong thing,

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread David Miller
From: Wei Shuai Date: Mon, 21 Jan 2013 10:20:22 +0800 > The main problem is that these devices don't support ethernet. He's saying your comment is referring to the wrong thing, rather than saying anything against what your change is doing. Read his feedback carefully: >>> +/* Same as wwan_info

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread Wei Shuai
The main problem is that these devices don't support ethernet. They support IP (v4 and _maybe_ v6) with an ethernet header. Many of them will do ARP (and IPv6 ND) as well to complete the picture, but some of them don't and that's what these drivers try to deal with. Note that most of the devices

Re: [PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-20 Thread Sergei Shtylyov
Hello. On 20-01-2013 10:12, Wei Shuai wrote: Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Wrap your lines at 76-80 columns maximum please. Then more similiar NO ARP devices can be handled easily Signed-off-by:

[PATCH 2/2] CDC_NCM: adding support FLAG_NOARP for Infineon modem platform

2013-01-19 Thread Wei Shuai
Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Then more similiar NO ARP devices can be handled easily Signed-off-by: Wei Shuai --- drivers/net/usb/cdc_ncm.c | 21 + 1 files changed, 21 insertions(+),

[PATCH 2/2] CDC_NCM adding support FLAG_NOARP for Infineon modem platform

2013-01-19 Thread Wei Shuai
Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. we can define a new common structure wwan_noarp_info. Then more similiar NO ARP devices can be handled easily Signed-off-by: Wei Shuai --- drivers/net/usb/cdc_ncm.c | 21 + 1 files changed, 21 insertions(+),