Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-28 Thread Sebastian Andrzej Siewior
On Mon, Aug 27, 2012 at 04:33:05PM +0200, Michal Nazarewicz wrote: > PS. It just struck me, is there a reason for > USB_GADGET_COMPOSITE_OVERWRITE_OPTIONS to be a macro? It could be just > an exported function. I'm thinking something along the lines of: > > > struct usb_composite_overwrites { >

Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-27 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > On 08/25/2012 12:11 AM, Michal Nazarewicz wrote: >> Sebastian Andrzej Siewior writes: >>> This patch pushes the iManufacturer module argument from composite into >>> each gadget. Once the user uses the module paramter, the string is >>> overwritten with the f

Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/25/2012 12:11 AM, Michal Nazarewicz wrote: Sebastian Andrzej Siewior writes: This patch pushes the iManufacturer module argument from composite into each gadget. Once the user uses the module paramter, the string is overwritten with the final value. Why to remove the generation of the s

Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-24 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch pushes the iManufacturer module argument from composite into > each gadget. Once the user uses the module paramter, the string is > overwritten with the final value. Why to remove the generation of the string from those gadgets and let composite hand

[PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-24 Thread Sebastian Andrzej Siewior
This patch pushes the iManufacturer module argument from composite into each gadget. Once the user uses the module paramter, the string is overwritten with the final value. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/acm_ms.c |4 +++- drivers/usb/gadget/audio.c