Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-23 Thread Alan Stern
On Tue, 22 Jan 2013, Sascha Hauer wrote: > On Tue, Jan 22, 2013 at 03:38:55PM +, Arnd Bergmann wrote: > > On Tuesday 22 January 2013, Alan Stern wrote: > > > In order to prevent this, you have to make sure that each glue driver > > > depends on USB_ARCH_HAS_EHCI. A simple way to do this is to

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Sascha Hauer
On Tue, Jan 22, 2013 at 03:38:55PM +, Arnd Bergmann wrote: > On Tuesday 22 January 2013, Alan Stern wrote: > > In order to prevent this, you have to make sure that each glue driver > > depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround > > the Kconfig entries for those driver

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Arnd Bergmann
On Tuesday 22 January 2013, Alan Stern wrote: > In order to prevent this, you have to make sure that each glue driver > depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround > the Kconfig entries for those drivers with "if USB && > USB_ARCH_HAS_EHCI" ... "endif". I was actually th

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Shawn Guo wrote: > On Mon, Jan 21, 2013 at 09:37:42PM +, Arnd Bergmann wrote: > > > Arnd, please take a look at > > > > > > http://marc.info/?l=linux-usb&m=135843716515529&w=2 > > > > > > I can't test it easily, not being set up for cross compilation. I'm > > >

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Manjunath Goudar wrote: > > > I think we can actually > > > get the same results by turning the Kconfig logic around and making > > > the platform glue drivers 'select USB_EHCI_HCD' than depending on > > > it. > > > > That's a good idea. The Kconfig changes would have to be

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Shawn Guo
On Tue, Jan 22, 2013 at 02:11:18PM +0800, Shawn Guo wrote: > Alan, > > Thanks for the patch. I just gave it try. The USB Host port still > works for me with a couple of fixes on your changes integrated (one > for compiling and the other for probing). So you have my ACK with > the changes below

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Shawn Guo
On Mon, Jan 21, 2013 at 09:37:42PM +, Arnd Bergmann wrote: > > Arnd, please take a look at > > > > http://marc.info/?l=linux-usb&m=135843716515529&w=2 > > > > I can't test it easily, not being set up for cross compilation. I'm > > waiting to hear from anybody whether it works before

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Alan Stern
On Mon, 21 Jan 2013, Arnd Bergmann wrote: > Alan, one comment about your version: You keep maintaining the > '#if IS_ENABLED' list in the main driver, which I think can actually > get removed now. I considered doing that. The benefit of keeping it is that it warns about configs where the main d

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Alan Stern wrote: > Is Manjunath aware of the first patch attached to this email message? > > http://marc.info/?l=linux-usb&m=135843902916416&w=2 > I would not expect so. Manjunath is still learning about the open source processes, but he has also done a simila

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Alan Stern wrote: > On Mon, 21 Jan 2013, Felipe Balbi wrote: > > > On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: > > > In linux-3.8-rc1 it became possible to build the imx and > > > mvebu platforms together in a single kernel, which clashes > > > in the

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Alan Stern
On Mon, 21 Jan 2013, Arnd Bergmann wrote: > On Monday 21 January 2013, Felipe Balbi wrote: > > On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: > > > Manjunath Goudar is already working on a patch to convert > > > both the imx and the mvebu glue drivers (along with all > > > the othe

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Felipe Balbi wrote: > On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: > > Manjunath Goudar is already working on a patch to convert > > both the imx and the mvebu glue drivers (along with all > > the other ARM specific ones) to the new probing method, > > b

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Alan Stern
On Mon, 21 Jan 2013, Felipe Balbi wrote: > On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: > > In linux-3.8-rc1 it became possible to build the imx and > > mvebu platforms together in a single kernel, which clashes > > in the ehci driver. > > > > Manjunath Goudar is already working

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Felipe Balbi
On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: > In linux-3.8-rc1 it became possible to build the imx and > mvebu platforms together in a single kernel, which clashes > in the ehci driver. > > Manjunath Goudar is already working on a patch to convert > both the imx and the mvebu gl

[PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
In linux-3.8-rc1 it became possible to build the imx and mvebu platforms together in a single kernel, which clashes in the ehci driver. Manjunath Goudar is already working on a patch to convert both the imx and the mvebu glue drivers (along with all the other ARM specific ones) to the new probing