On 11/27/2012 03:28 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Nov 27, 2012 at 02:10:50PM +0200, Roger Quadros wrote:
>>> in fact, I would convert this construct into a switch which would look
>>> like:
>>>
>>> reg &= ~(OMAP4_P1_MODE_MASK << i * 2);
>>>
>>> switch (port_mode[i]) {
>>> case OMAP4_P1
Hi,
On Tue, Nov 27, 2012 at 02:10:50PM +0200, Roger Quadros wrote:
> > in fact, I would convert this construct into a switch which would look
> > like:
> >
> > reg &= ~(OMAP4_P1_MODE_MASK << i * 2);
> >
> > switch (port_mode[i]) {
> > case OMAP4_P1_MODE_TLL:
> > reg |= OMAP4_P1_MODE_TLL << i
On 11/21/2012 03:52 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
>> OMAPs till date can have upto 3 ports. We need to initialize
>
> s/upto/up to/
>
>> the port mode in HOSTCONFIG register for all of them.
>
> why *all* of them ? Isn't it enough to ini
hi,
On Wed, Nov 21, 2012 at 05:47:06PM +0200, Roger Quadros wrote:
> On 11/21/2012 03:52 PM, Felipe Balbi wrote:
> > On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
> >> OMAPs till date can have upto 3 ports. We need to initialize
> >
> > s/upto/up to/
> >
> >> the port mode in HO
On 11/21/2012 03:52 PM, Felipe Balbi wrote:
> On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
>> OMAPs till date can have upto 3 ports. We need to initialize
>
> s/upto/up to/
>
>> the port mode in HOSTCONFIG register for all of them.
>
> why *all* of them ? Isn't it enough to ini
On Thu, Nov 15, 2012 at 04:34:08PM +0200, Roger Quadros wrote:
> OMAPs till date can have upto 3 ports. We need to initialize
s/upto/up to/
> the port mode in HOSTCONFIG register for all of them.
why *all* of them ? Isn't it enough to initialize only the ones we're
going to use ? If not, why ?
OMAPs till date can have upto 3 ports. We need to initialize
the port mode in HOSTCONFIG register for all of them.
Signed-off-by: Roger Quadros
---
drivers/mfd/omap-usb-host.c | 31 ---
1 files changed, 12 insertions(+), 19 deletions(-)
diff --git a/drivers/mfd/oma
